[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Window Switcher layouts follow Plasma Package structure
From: "Commit Hook" <null () kde ! org>
Date: 2012-02-16 9:08:39
Message-ID: 20120216090839.14181.14200 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103951/#review10674
-----------------------------------------------------------
This review has been submitted with commit f7cca33ed0b977b43dc3a5dba1742034=
57b8c042 by Martin Gr=C3=A4=C3=9Flin to branch master.
- Commit Hook
On Feb. 12, 2012, 2:22 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103951/
> -----------------------------------------------------------
> =
> (Updated Feb. 12, 2012, 2:22 p.m.)
> =
> =
> Review request for kwin and Marco Martin.
> =
> =
> Description
> -------
> =
> A new service type is introduced which is used by the KCM to find all ava=
ilable window switcher layouts. This makes it finally possible to have 3rd =
party window switchers.
> =
> Also the tabbox finds the packaged QML file through the service definitio=
ns.
> =
> @notmart: you are only included to be made aware that I plan to move the =
window_strip.qml file around :-)
> =
> =
> Diffs
> -----
> =
> kwin/CMakeLists.txt c741cb4 =
> kwin/kcmkwin/kwintabbox/layoutconfig.cpp 84b7d30 =
> kwin/tabbox/CMakeLists.txt PRE-CREATION =
> kwin/tabbox/declarative.cpp dd4f242 =
> kwin/tabbox/kwinwindowswitcher.desktop PRE-CREATION =
> kwin/tabbox/qml/CMakeLists.txt PRE-CREATION =
> kwin/tabbox/qml/big_icons.qml a95264e =
> kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml PRE-CREATION =
> kwin/tabbox/qml/clients/big_icons/metadata.desktop PRE-CREATION =
> kwin/tabbox/qml/clients/compact/contents/ui/main.qml PRE-CREATION =
> kwin/tabbox/qml/clients/compact/metadata.desktop PRE-CREATION =
> kwin/tabbox/qml/clients/informative/contents/ui/main.qml PRE-CREATION =
> kwin/tabbox/qml/clients/informative/metadata.desktop PRE-CREATION =
> kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml PRE-CREATION =
> kwin/tabbox/qml/clients/small_icons/metadata.desktop PRE-CREATION =
> kwin/tabbox/qml/clients/text/contents/ui/main.qml PRE-CREATION =
> kwin/tabbox/qml/clients/text/metadata.desktop PRE-CREATION =
> kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml PRE-CREATION =
> kwin/tabbox/qml/clients/thumbnails/metadata.desktop PRE-CREATION =
> kwin/tabbox/qml/clients/window_strip/contents/ui/main.qml PRE-CREATION =
> kwin/tabbox/qml/clients/window_strip/metadata.desktop PRE-CREATION =
> kwin/tabbox/qml/compact.qml 9504789 =
> kwin/tabbox/qml/informative.qml 9ec8757 =
> kwin/tabbox/qml/small_icons.qml ea09ed0 =
> kwin/tabbox/qml/text.qml 669a541 =
> kwin/tabbox/qml/thumbnails.qml a0bb073 =
> kwin/tabbox/qml/window_strip.qml d242f68 =
> =
> Diff: http://git.reviewboard.kde.org/r/103951/diff/
> =
> =
> Testing
> -------
> =
> Yes :-)
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103951/">http://git.reviewboard.kde.org/r/103951/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f7cca33ed0b977b43dc3a5dba174203457b8c042 by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 12th, 2012, 2:22 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Marco Martin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2012, 2:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A new service type is introduced which is used by the KCM to find all \
available window switcher layouts. This makes it finally possible to have 3rd party \
window switchers.
Also the tabbox finds the packaged QML file through the service definitions.
@notmart: you are only included to be made aware that I plan to move the \
window_strip.qml file around :-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes :-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: grey">(c741cb4)</span></li>
<li>kwin/kcmkwin/kwintabbox/layoutconfig.cpp <span style="color: \
grey">(84b7d30)</span></li>
<li>kwin/tabbox/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(dd4f242)</span></li>
<li>kwin/tabbox/kwinwindowswitcher.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/big_icons.qml <span style="color: grey">(a95264e)</span></li>
<li>kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/big_icons/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/compact/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/compact/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/informative/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/informative/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/small_icons/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/text/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/text/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/thumbnails/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/window_strip/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/window_strip/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/compact.qml <span style="color: grey">(9504789)</span></li>
<li>kwin/tabbox/qml/informative.qml <span style="color: grey">(9ec8757)</span></li>
<li>kwin/tabbox/qml/small_icons.qml <span style="color: grey">(ea09ed0)</span></li>
<li>kwin/tabbox/qml/text.qml <span style="color: grey">(669a541)</span></li>
<li>kwin/tabbox/qml/thumbnails.qml <span style="color: grey">(a0bb073)</span></li>
<li>kwin/tabbox/qml/window_strip.qml <span style="color: grey">(d242f68)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103951/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic