[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Remove "Display borders on maximized windows"
From: "Hugo Pereira Da Costa" <hugo () oxygen-icons ! org>
Date: 2012-02-14 6:24:41
Message-ID: 20120214062441.22494.53968 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103948/#review10623
-----------------------------------------------------------
Not tested yet, but ...
Concerning the issue about button placements:
1- fortunately I don't think many people use the "Huge" settings, though yo=
u also have the issue (to a lesser extend) for smaller borders. Yes/no ?
2- moving them away from the border permanently, not an option from design =
pov
3- moving the buttons dynamically I think is more approppriate. In fact we =
already do that for maximized windows, using the "isMaximized()" function
Since we are happily breaking API for tabbing, why not introduce some quick=
TileMode() method, and/or quickTileModeChanged() or whatever mode you find =
appropriate ?
- Hugo Pereira Da Costa
On Feb. 12, 2012, 2:54 a.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103948/
> -----------------------------------------------------------
> =
> (Updated Feb. 12, 2012, 2:54 a.m.)
> =
> =
> Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Hugo Pereira Da Cos=
ta.
> =
> =
> Description
> -------
> =
> Actually the only thing the patch does not is what's stated in the summar=
y ;-)
> =
> It's currently meant as an initial tryout.
> =
> - The setting is ignored, the decoration always gets a "true" for it
> - moving a maximized window requires breaking a hardcoded snap (unless yo=
u use quick maximization)
> - all snapping, maximization and quicktiling is done towards the client, =
not the frame, ie. ideally you can QT to the right and have fitt's law on t=
he scrollbar (leaving aside that clients like to have frames there) but als=
o just snap a window there (if you've border snapping activated)
> - counter window snapping remains on the frame
> * on the fly fix a bug on quick maximization (offsetting it by half the w=
indow size is not correct for normal windows, only those with size restrict=
ions)
> =
> TODO: several sane implementations for currently hardcoded stuff and heur=
istics, requires Deco API extension; general code cleanup in geometry.cpp (=
it's still a bit a mess)
> =
> @Hugo
> This rises a "problem" with decorations and buttons. If the deco has a HU=
GE frame buttons can be snapped away, in this case I guess the most sane so=
lution would be to impadd them, but i guess Nuno will have a different opin=
ion, so there likely should be a way to signal the deco the quick tile (and=
snapping - no idea how we'll separate that from "just out of screen") stat=
e.
> =
> =
> Diffs
> -----
> =
> kwin/client.cpp 34e9006 =
> kwin/geometry.cpp 6d47078 =
> kwin/libkdecorations/kdecoration.h 442d0a1 =
> kwin/libkdecorations/kdecoration.cpp f26699a =
> kwin/libkdecorations/kdecoration_p.h 71833cd =
> kwin/libkdecorations/kdecoration_p.cpp 1e01618 =
> =
> Diff: http://git.reviewboard.kde.org/r/103948/diff/
> =
> =
> Testing
> -------
> =
> Yeah, snapped a bit
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103948/">http://git.reviewboard.kde.org/r/103948/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not tested yet, but ...
Concerning the issue about button placements:
1- fortunately I don't think many people use the "Huge" settings, \
though you also have the issue (to a lesser extend) for smaller borders. Yes/no ? 2- \
moving them away from the border permanently, not an option from design pov 3- moving \
the buttons dynamically I think is more approppriate. In fact we already do that for \
maximized windows, using the "isMaximized()" function Since we are happily \
breaking API for tabbing, why not introduce some quickTileMode() method, and/or \
quickTileModeChanged() or whatever mode you find appropriate ? </pre>
<br />
<p>- Hugo</p>
<br />
<p>On February 12th, 2012, 2:54 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2012, 2:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Actually the only thing the patch does not is what's stated in the \
summary ;-)
It's currently meant as an initial tryout.
- The setting is ignored, the decoration always gets a "true" for it
- moving a maximized window requires breaking a hardcoded snap (unless you use quick \
maximization)
- all snapping, maximization and quicktiling is done towards the client, not the \
frame, ie. ideally you can QT to the right and have fitt's law on the scrollbar \
(leaving aside that clients like to have frames there) but also just snap a window \
there (if you've border snapping activated)
- counter window snapping remains on the frame
* on the fly fix a bug on quick maximization (offsetting it by half the window size \
is not correct for normal windows, only those with size restrictions)
TODO: several sane implementations for currently hardcoded stuff and heuristics, \
requires Deco API extension; general code cleanup in geometry.cpp (it's still a \
bit a mess)
@Hugo
This rises a "problem" with decorations and buttons. If the deco has a HUGE \
frame buttons can be snapped away, in this case I guess the most sane solution would \
be to impadd them, but i guess Nuno will have a different opinion, so there likely \
should be a way to signal the deco the quick tile (and snapping - no idea how \
we'll separate that from "just out of screen") state.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yeah, snapped a bit</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(34e9006)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(6d47078)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(442d0a1)</span></li>
<li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(f26699a)</span></li>
<li>kwin/libkdecorations/kdecoration_p.h <span style="color: \
grey">(71833cd)</span></li>
<li>kwin/libkdecorations/kdecoration_p.cpp <span style="color: \
grey">(1e01618)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103948/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic