'Re: Review Request: Fix NPOT shadows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Fix NPOT shadows
From:       "Commit Hook" <null () kde ! org>
Date:       2012-02-09 18:07:51
Message-ID: 20120209180751.1635.65693 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103888/#review10463
-----------------------------------------------------------

This review has been submitted with commit 4281fd09be344bfa99b0450eae384b49b55db152 \
by Thomas Lübking to branch master.

- Commit Hook

On Feb. 8, 2012, 5:38 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103888/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2012, 5:38 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> As confirmed in bug #293325
> 
> This
> a) fixes the texture offset calculation
> b) arranges he shadow pixmaps as border in the texture to avoid interpolation \
> issues. 
> 
> This addresses bugs 280116, 282882, 291161, and 293325.
> http://bugs.kde.org/show_bug.cgi?id=280116
> http://bugs.kde.org/show_bug.cgi?id=282882
> http://bugs.kde.org/show_bug.cgi?id=291161
> http://bugs.kde.org/show_bug.cgi?id=293325
> 
> 
> Diffs
> -----
> 
> kwin/scene_opengl.cpp ab2d24d 
> 
> Diff: http://git.reviewboard.kde.org/r/103888/diff/diff
> 
> 
> Testing
> -------
> 
> Yes, see test line.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103888/">http://git.reviewboard.kde.org/r/103888/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 4281fd09be344bfa99b0450eae384b49b55db152 by Thomas Lübking to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On February 8th, 2012, 5:38 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Feb. 8, 2012, 5:38 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As confirmed in bug #293325

This
a) fixes the texture offset calculation
b) arranges he shadow pixmaps as border in the texture to avoid interpolation \
issues.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, see test line.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=280116">280116</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=282882">282882</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=291161">291161</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=293325">293325</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scene_opengl.cpp <span style="color: grey">(ab2d24d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103888/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 