[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Selective rule remembering
From: "Commit Hook" <null () kde ! org>
Date: 2012-02-09 17:07:17
Message-ID: 20120209170717.30002.25761 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103875/#review10461
-----------------------------------------------------------
This review has been submitted with commit 722e21d920324b5ad93e69c4eda31276=
603dfdca by Thomas L=C3=BCbking to branch master.
- Commit Hook
On Feb. 5, 2012, 5:57 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103875/
> -----------------------------------------------------------
> =
> (Updated Feb. 5, 2012, 5:57 p.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> To avoid conflicts* during ::manage() esp. when setOnActivity() still upd=
ated rules and by this in order to ever add activity rules, this patch make=
s the rule remembering selective, ie. :updateWindowRules() takes a flag par=
ameter to signal what settings to remember now.
> =
> It would also allow us to control whether eg. to remember size & position=
for a maximization change (but that actually works anyway, not yet checked=
why)
> =
> *updateRules() used to store desktop/geometry etc. when setting the activ=
itym but before applying the actually remembered value.
> =
> =
> Diffs
> -----
> =
> kwin/client.h 159e8f3 =
> kwin/client.cpp 8b545b4 =
> kwin/geometry.cpp bfc304b =
> kwin/layers.cpp 94bfc29 =
> kwin/manage.cpp c551eac =
> kwin/rules.h 0f988ee =
> kwin/rules.cpp 52b32fe =
> =
> Diff: http://git.reviewboard.kde.org/r/103875/diff/diff
> =
> =
> Testing
> -------
> =
> Tested remembering maximization, desktop, size and position for an xterm =
- all still operative.
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103875/">http://git.reviewboard.kde.org/r/103875/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 722e21d920324b5ad93e69c4eda31276603dfdca by Thomas Lübking to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 5th, 2012, 5:57 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2012, 5:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To avoid conflicts* during ::manage() esp. when setOnActivity() still \
updated rules and by this in order to ever add activity rules, this patch makes the \
rule remembering selective, ie. :updateWindowRules() takes a flag parameter to signal \
what settings to remember now.
It would also allow us to control whether eg. to remember size & position for a \
maximization change (but that actually works anyway, not yet checked why)
*updateRules() used to store desktop/geometry etc. when setting the activitym but \
before applying the actually remembered value.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested remembering maximization, desktop, size and position for an xterm \
- all still operative.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.h <span style="color: grey">(159e8f3)</span></li>
<li>kwin/client.cpp <span style="color: grey">(8b545b4)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(bfc304b)</span></li>
<li>kwin/layers.cpp <span style="color: grey">(94bfc29)</span></li>
<li>kwin/manage.cpp <span style="color: grey">(c551eac)</span></li>
<li>kwin/rules.h <span style="color: grey">(0f988ee)</span></li>
<li>kwin/rules.cpp <span style="color: grey">(52b32fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103875/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic