[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Only keep windows fullscreen for topmost transients, not random group members
From: "Commit Hook" <null () kde ! org>
Date: 2012-02-08 19:52:35
Message-ID: 20120208195235.14624.39322 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103866/#review10428
-----------------------------------------------------------
This review has been submitted with commit 10cd4faa8a0cb0619ebcfd462ee0104b1db58171 \
by Thomas Lübking to branch master.
- Commit Hook
On Feb. 4, 2012, 3:56 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103866/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2012, 3:56 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> see subject, the original comment and the NETWM spec also say so
>
> - focused windows having state _NET_WM_STATE_FULLSCREEN
> Windows that are transient for another window should be kept above this window.
>
> There's no comment about "group" members.
>
> Todo: i guess the unused "ac" variant would cause the behavior demanded by NETWM \
> (focused rather than "on top") but i don't know why this was commented..
>
> This addresses bug 293265.
> http://bugs.kde.org/show_bug.cgi?id=293265
>
>
> Diffs
> -----
>
> kwin/layers.cpp 31d1c49
>
> Diff: http://git.reviewboard.kde.org/r/103866/diff/diff
>
>
> Testing
> -------
>
> Solves bug 293265, dolphin remains fullscreen when activating any of it's \
> transients and the smplayer dock also still works.
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103866/">http://git.reviewboard.kde.org/r/103866/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 10cd4faa8a0cb0619ebcfd462ee0104b1db58171 by Thomas Lübking to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 4th, 2012, 3:56 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2012, 3:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see subject, the original comment and the NETWM spec also say so
- focused windows having state _NET_WM_STATE_FULLSCREEN
Windows that are transient for another window should be kept above this window.
There's no comment about "group" members.
Todo: i guess the unused "ac" variant would cause the behavior demanded by \
NETWM (focused rather than "on top") but i don't know why this was \
commented..</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Solves bug 293265, dolphin remains fullscreen when activating any of \
it's transients and the smplayer dock also still works.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=293265">293265</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/layers.cpp <span style="color: grey">(31d1c49)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103866/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic