'Re: Review Request: several GLTexture related improvements'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: several GLTexture related improvements
From:       "Commit Hook" <null () kde ! org>
Date:       2012-01-31 22:15:51
Message-ID: 20120131221551.2361.2668 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103655/#review10262
-----------------------------------------------------------

This review has been submitted with commit f6cef28ebd6d832e13f0cf7d4b81ed5d3e0aae2c \
by Philipp Knechtges to branch master.

- Commit Hook

On Jan. 27, 2012, 9:19 p.m., Philipp Knechtges wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103655/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2012, 9:19 p.m.)
> 
> 
> Review request for kwin and Fredrik Höglund.
> 
> 
> Description
> -------
> 
> This RR is based on 4 commits:
> * This first patch allows us to track the GLTexture wrapmode internally.
> * The second patch improves the texture update handling:
> It changes the behavior of strictly bound textures such that
> they are only updated if the corresponding window has been damaged.
> Additionally GLTexture now keeps track of the current filter setting.
> * The third patch avoids unnecessary texture binds within performPaint.
> * The last patch cleans up the GLTexture API.
> 
> 
> Diffs
> -----
> 
> kwin/scene_opengl_egl.cpp 90841338f5c07ca76cd0a96c2c2dc2ce9cb51dc6 
> kwin/scene_opengl_glx.cpp d978605bb9ebb60f0e1f9ab20f1bb40e88aed20e 
> kwin/scene_opengl.h 5bc9d5e9365fa25b4e266d8ccc1c1dcd33148977 
> kwin/scene_opengl.cpp 18cbd76a1c8f6abfe1bb5d96c51518498abd99c8 
> kwin/libkwineffects/kwingltexture_p.h 7e04305a92f29ac8b7b7e662d7c5f4f6935c0fc3 
> kwin/libkwineffects/kwingltexture.cpp 4155fb16f35d256a326111e8c1ab7998f36026e6 
> kwin/libkwineffects/kwingltexture.h 6795d0dbf1f9a8d6359a234ceac6ab1c6aa27a0b 
> 
> Diff: http://git.reviewboard.kde.org/r/103655/diff/diff
> 
> 
> Testing
> -------
> 
> nvidia blob works with QT_GRAPHICSSYSTEM=raster/native and GL2/GL1.
> Would be nice if somebody could test it with hardware which really requires the \
> strict texture binding. 
> 
> Thanks,
> 
> Philipp Knechtges
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103655/">http://git.reviewboard.kde.org/r/103655/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f6cef28ebd6d832e13f0cf7d4b81ed5d3e0aae2c by Philipp Knechtges \
to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 27th, 2012, 9:19 p.m., Philipp Knechtges wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Fredrik Höglund.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated Jan. 27, 2012, 9:19 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">This RR is based on 4 commits:
* This first patch allows us to track the GLTexture wrapmode internally.
* The second patch improves the texture update handling:
  It changes the behavior of strictly bound textures such that
  they are only updated if the corresponding window has been damaged.
  Additionally GLTexture now keeps track of the current filter setting.
* The third patch avoids unnecessary texture binds within performPaint.
* The last patch cleans up the GLTexture API.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">nvidia blob works with QT_GRAPHICSSYSTEM=raster/native and GL2/GL1. \
Would be nice if somebody could test it with hardware which really requires the \
strict texture binding.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scene_opengl_egl.cpp <span style="color: \
grey">(90841338f5c07ca76cd0a96c2c2dc2ce9cb51dc6)</span></li>

 <li>kwin/scene_opengl_glx.cpp <span style="color: \
grey">(d978605bb9ebb60f0e1f9ab20f1bb40e88aed20e)</span></li>

 <li>kwin/scene_opengl.h <span style="color: \
grey">(5bc9d5e9365fa25b4e266d8ccc1c1dcd33148977)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: \
grey">(18cbd76a1c8f6abfe1bb5d96c51518498abd99c8)</span></li>

 <li>kwin/libkwineffects/kwingltexture_p.h <span style="color: \
grey">(7e04305a92f29ac8b7b7e662d7c5f4f6935c0fc3)</span></li>

 <li>kwin/libkwineffects/kwingltexture.cpp <span style="color: \
grey">(4155fb16f35d256a326111e8c1ab7998f36026e6)</span></li>

 <li>kwin/libkwineffects/kwingltexture.h <span style="color: \
grey">(6795d0dbf1f9a8d6359a234ceac6ab1c6aa27a0b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103655/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 