From kwin  Mon Jan 30 09:31:18 2012
From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= <kde () martin-graesslin ! com>
Date: Mon, 30 Jan 2012 09:31:18 +0000
To: kwin
Subject: Re: Review Request: JavaScript bindings for KWin Effects
Message-Id: <20120130093118.4533.7509 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kwin&m=132791607812005
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============7092674535466688840=="

--===============7092674535466688840==
Content-Type: multipart/alternative;
	boundary="===============4863444965842245746=="

--===============4863444965842245746==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103823/
-----------------------------------------------------------

(Updated Jan. 30, 2012, 9:31 a.m.)


Review request for kwin.


Changes
-------

Script wrapper for FPx2. Following values are supported:
null -> FPx2()
real -> FPx2(value)
{
value1: real,
value2: real
}
-> FPx2(value1, value2)

with that I hope that the animate method is no longer limited (and API is n=
icer). Next step: meta


Description
-------

The bindings are based on AnimationEffect. So Thomas please have a look whe=
ther I use it correctly :-) The method is exported multiple times as I did =
not want to wrap the FPx2 class.

An example script for fade effect:
var duration =3D 250;
effects.windowAdded.connect(function(w) {
    effect.animate(w, Effect.Opacity, duration, 1.0);
});
effects.windowClosed.connect(function(w) {
    effect.animate(w, Effect.Opacity, duration, 0.0, 1.0);
});

There is quite some work to be done. EffectWindow does not yet have propert=
ies, for EffectsHandler probably some more methods might be exported.

Unfortunately I had to change the signature of the signals as QtScript need=
s the type being exported as a metatype and metatypes want full name.


Diffs (updated)
-----

  kwin/CMakeLists.txt c4b75c0 =

  kwin/effects.h 28ab72c =

  kwin/effects.cpp 4f55799 =

  kwin/effects/blur/blur.h 65ba381 =

  kwin/effects/blur/blur.cpp 06c6854 =

  kwin/effects/boxswitch/boxswitch.h cfb6b47 =

  kwin/effects/boxswitch/boxswitch.cpp fac6b3f =

  kwin/effects/coverswitch/coverswitch.h b49a36e =

  kwin/effects/coverswitch/coverswitch.cpp bdf2fbe =

  kwin/effects/cube/cubeslide.h ffbda88 =

  kwin/effects/cube/cubeslide.cpp ed1f518 =

  kwin/effects/dashboard/dashboard.h 46d3e98 =

  kwin/effects/dashboard/dashboard.cpp 4f6dc65 =

  kwin/effects/desktopgrid/desktopgrid.h b420389 =

  kwin/effects/desktopgrid/desktopgrid.cpp 925d2f1 =

  kwin/effects/dialogparent/dialogparent.h 439c67e =

  kwin/effects/dialogparent/dialogparent.cpp ac9493a =

  kwin/effects/diminactive/diminactive.h 24a80de =

  kwin/effects/diminactive/diminactive.cpp 6978f36 =

  kwin/effects/dimscreen/dimscreen.h ee8c114 =

  kwin/effects/dimscreen/dimscreen.cpp fd4c15a =

  kwin/effects/explosion/explosion.h 8a343c7 =

  kwin/effects/explosion/explosion.cpp dc9cd14 =

  kwin/effects/fade/fade.h 38c0040 =

  kwin/effects/fade/fade.cpp 213516b =

  kwin/effects/fallapart/fallapart.h acc1446 =

  kwin/effects/fallapart/fallapart.cpp 5db5ee7 =

  kwin/effects/flipswitch/flipswitch.h 559e88b =

  kwin/effects/flipswitch/flipswitch.cpp f7f4307 =

  kwin/effects/glide/glide.h 0003345 =

  kwin/effects/glide/glide.cpp 99a8c8b =

  kwin/effects/highlightwindow/highlightwindow.h 8b46bd4 =

  kwin/effects/highlightwindow/highlightwindow.cpp f048cfb =

  kwin/effects/invert/invert.h 3dc49fb =

  kwin/effects/invert/invert.cpp 0ef1545 =

  kwin/effects/login/login.h db30044 =

  kwin/effects/login/login.cpp a9da287 =

  kwin/effects/logout/logout.h f08152f =

  kwin/effects/logout/logout.cpp 4e97ebe =

  kwin/effects/magiclamp/magiclamp.h 8000081 =

  kwin/effects/magiclamp/magiclamp.cpp f7f73b4 =

  kwin/effects/minimizeanimation/minimizeanimation.h 27e0dd3 =

  kwin/effects/minimizeanimation/minimizeanimation.cpp 44d15ec =

  kwin/effects/presentwindows/presentwindows.h 08aa262 =

  kwin/effects/presentwindows/presentwindows.cpp dc4d5c5 =

  kwin/effects/resize/resize.h 0411d6d =

  kwin/effects/resize/resize.cpp 84bdd7f =

  kwin/effects/scalein/scalein.h 8ae7504 =

  kwin/effects/scalein/scalein.cpp 25d78df =

  kwin/effects/screenshot/screenshot.h 22385a3 =

  kwin/effects/screenshot/screenshot.cpp 6bd18e3 =

  kwin/effects/sheet/sheet.h 7ec739b =

  kwin/effects/sheet/sheet.cpp 9156f0d =

  kwin/effects/slideback/slideback.h 0cba556 =

  kwin/effects/slideback/slideback.cpp 380b3d5 =

  kwin/effects/slidingpopups/slidingpopups.h eca9e2e =

  kwin/effects/slidingpopups/slidingpopups.cpp 8fb0608 =

  kwin/effects/snaphelper/snaphelper.h ee60f8f =

  kwin/effects/snaphelper/snaphelper.cpp a30cc60 =

  kwin/effects/taskbarthumbnail/taskbarthumbnail.h 77e5294 =

  kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp 1ce6233 =

  kwin/effects/thumbnailaside/thumbnailaside.h 323e2fd =

  kwin/effects/thumbnailaside/thumbnailaside.cpp 3a1b4e0 =

  kwin/effects/translucency/translucency.h fa7b85c =

  kwin/effects/translucency/translucency.cpp 4e6d58d =

  kwin/effects/windowgeometry/windowgeometry.h ba20c05 =

  kwin/effects/windowgeometry/windowgeometry.cpp a9fd796 =

  kwin/effects/wobblywindows/wobblywindows.h d4844d3 =

  kwin/effects/wobblywindows/wobblywindows.cpp c7d30fe =

  kwin/libkwineffects/kwinanimationeffect.h 106155c =

  kwin/libkwineffects/kwinanimationeffect.cpp 00a7887 =

  kwin/libkwineffects/kwineffects.h 491ec58 =

  kwin/scripting/scriptedeffect.h PRE-CREATION =

  kwin/scripting/scriptedeffect.cpp PRE-CREATION =

  kwin/thumbnailitem.cpp 73441a0 =


Diff: http://git.reviewboard.kde.org/r/103823/diff/diff


Testing
-------


Thanks,

Martin Gr=C3=A4=C3=9Flin


--===============4863444965842245746==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://git.reviewboard.kde.org/r/103823/">http://git.revie=
wboard.kde.org/r/103823/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gr=C3=A4=C3=9Flin.</div>


<p style=3D"color: grey;"><i>Updated Jan. 30, 2012, 9:31 a.m.</i></p>



<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</=
h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Script wrapper for FPx2. Following values are supported:
null -&gt; FPx2()
real -&gt; FPx2(value)
{
value1: real,
value2: real
}
-&gt; FPx2(value1, value2)

with that I hope that the animate method is no longer limited (and API is n=
icer). Next step: meta</pre>
  </td>
 </tr>
</table>




<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
 <table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">The bindings are based on AnimationEffect. So Thomas please =
have a look whether I use it correctly :-) The method is exported multiple =
times as I did not want to wrap the FPx2 class.

An example script for fade effect:
var duration =3D 250;
effects.windowAdded.connect(function(w) {
    effect.animate(w, Effect.Opacity, duration, 1.0);
});
effects.windowClosed.connect(function(w) {
    effect.animate(w, Effect.Opacity, duration, 0.0, 1.0);
});

There is quite some work to be done. EffectWindow does not yet have propert=
ies, for EffectsHandler probably some more methods might be exported.

Unfortunately I had to change the signature of the signals as QtScript need=
s the type being exported as a metatype and metatypes want full name.</pre>
  </td>
 </tr>
</table>





<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 (updated)</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>kwin/CMakeLists.txt <span style=3D"color: grey">(c4b75c0)</span></li>

 <li>kwin/effects.h <span style=3D"color: grey">(28ab72c)</span></li>

 <li>kwin/effects.cpp <span style=3D"color: grey">(4f55799)</span></li>

 <li>kwin/effects/blur/blur.h <span style=3D"color: grey">(65ba381)</span><=
/li>

 <li>kwin/effects/blur/blur.cpp <span style=3D"color: grey">(06c6854)</span=
></li>

 <li>kwin/effects/boxswitch/boxswitch.h <span style=3D"color: grey">(cfb6b4=
7)</span></li>

 <li>kwin/effects/boxswitch/boxswitch.cpp <span style=3D"color: grey">(fac6=
b3f)</span></li>

 <li>kwin/effects/coverswitch/coverswitch.h <span style=3D"color: grey">(b4=
9a36e)</span></li>

 <li>kwin/effects/coverswitch/coverswitch.cpp <span style=3D"color: grey">(=
bdf2fbe)</span></li>

 <li>kwin/effects/cube/cubeslide.h <span style=3D"color: grey">(ffbda88)</s=
pan></li>

 <li>kwin/effects/cube/cubeslide.cpp <span style=3D"color: grey">(ed1f518)<=
/span></li>

 <li>kwin/effects/dashboard/dashboard.h <span style=3D"color: grey">(46d3e9=
8)</span></li>

 <li>kwin/effects/dashboard/dashboard.cpp <span style=3D"color: grey">(4f6d=
c65)</span></li>

 <li>kwin/effects/desktopgrid/desktopgrid.h <span style=3D"color: grey">(b4=
20389)</span></li>

 <li>kwin/effects/desktopgrid/desktopgrid.cpp <span style=3D"color: grey">(=
925d2f1)</span></li>

 <li>kwin/effects/dialogparent/dialogparent.h <span style=3D"color: grey">(=
439c67e)</span></li>

 <li>kwin/effects/dialogparent/dialogparent.cpp <span style=3D"color: grey"=
>(ac9493a)</span></li>

 <li>kwin/effects/diminactive/diminactive.h <span style=3D"color: grey">(24=
a80de)</span></li>

 <li>kwin/effects/diminactive/diminactive.cpp <span style=3D"color: grey">(=
6978f36)</span></li>

 <li>kwin/effects/dimscreen/dimscreen.h <span style=3D"color: grey">(ee8c11=
4)</span></li>

 <li>kwin/effects/dimscreen/dimscreen.cpp <span style=3D"color: grey">(fd4c=
15a)</span></li>

 <li>kwin/effects/explosion/explosion.h <span style=3D"color: grey">(8a343c=
7)</span></li>

 <li>kwin/effects/explosion/explosion.cpp <span style=3D"color: grey">(dc9c=
d14)</span></li>

 <li>kwin/effects/fade/fade.h <span style=3D"color: grey">(38c0040)</span><=
/li>

 <li>kwin/effects/fade/fade.cpp <span style=3D"color: grey">(213516b)</span=
></li>

 <li>kwin/effects/fallapart/fallapart.h <span style=3D"color: grey">(acc144=
6)</span></li>

 <li>kwin/effects/fallapart/fallapart.cpp <span style=3D"color: grey">(5db5=
ee7)</span></li>

 <li>kwin/effects/flipswitch/flipswitch.h <span style=3D"color: grey">(559e=
88b)</span></li>

 <li>kwin/effects/flipswitch/flipswitch.cpp <span style=3D"color: grey">(f7=
f4307)</span></li>

 <li>kwin/effects/glide/glide.h <span style=3D"color: grey">(0003345)</span=
></li>

 <li>kwin/effects/glide/glide.cpp <span style=3D"color: grey">(99a8c8b)</sp=
an></li>

 <li>kwin/effects/highlightwindow/highlightwindow.h <span style=3D"color: g=
rey">(8b46bd4)</span></li>

 <li>kwin/effects/highlightwindow/highlightwindow.cpp <span style=3D"color:=
 grey">(f048cfb)</span></li>

 <li>kwin/effects/invert/invert.h <span style=3D"color: grey">(3dc49fb)</sp=
an></li>

 <li>kwin/effects/invert/invert.cpp <span style=3D"color: grey">(0ef1545)</=
span></li>

 <li>kwin/effects/login/login.h <span style=3D"color: grey">(db30044)</span=
></li>

 <li>kwin/effects/login/login.cpp <span style=3D"color: grey">(a9da287)</sp=
an></li>

 <li>kwin/effects/logout/logout.h <span style=3D"color: grey">(f08152f)</sp=
an></li>

 <li>kwin/effects/logout/logout.cpp <span style=3D"color: grey">(4e97ebe)</=
span></li>

 <li>kwin/effects/magiclamp/magiclamp.h <span style=3D"color: grey">(800008=
1)</span></li>

 <li>kwin/effects/magiclamp/magiclamp.cpp <span style=3D"color: grey">(f7f7=
3b4)</span></li>

 <li>kwin/effects/minimizeanimation/minimizeanimation.h <span style=3D"colo=
r: grey">(27e0dd3)</span></li>

 <li>kwin/effects/minimizeanimation/minimizeanimation.cpp <span style=3D"co=
lor: grey">(44d15ec)</span></li>

 <li>kwin/effects/presentwindows/presentwindows.h <span style=3D"color: gre=
y">(08aa262)</span></li>

 <li>kwin/effects/presentwindows/presentwindows.cpp <span style=3D"color: g=
rey">(dc4d5c5)</span></li>

 <li>kwin/effects/resize/resize.h <span style=3D"color: grey">(0411d6d)</sp=
an></li>

 <li>kwin/effects/resize/resize.cpp <span style=3D"color: grey">(84bdd7f)</=
span></li>

 <li>kwin/effects/scalein/scalein.h <span style=3D"color: grey">(8ae7504)</=
span></li>

 <li>kwin/effects/scalein/scalein.cpp <span style=3D"color: grey">(25d78df)=
</span></li>

 <li>kwin/effects/screenshot/screenshot.h <span style=3D"color: grey">(2238=
5a3)</span></li>

 <li>kwin/effects/screenshot/screenshot.cpp <span style=3D"color: grey">(6b=
d18e3)</span></li>

 <li>kwin/effects/sheet/sheet.h <span style=3D"color: grey">(7ec739b)</span=
></li>

 <li>kwin/effects/sheet/sheet.cpp <span style=3D"color: grey">(9156f0d)</sp=
an></li>

 <li>kwin/effects/slideback/slideback.h <span style=3D"color: grey">(0cba55=
6)</span></li>

 <li>kwin/effects/slideback/slideback.cpp <span style=3D"color: grey">(380b=
3d5)</span></li>

 <li>kwin/effects/slidingpopups/slidingpopups.h <span style=3D"color: grey"=
>(eca9e2e)</span></li>

 <li>kwin/effects/slidingpopups/slidingpopups.cpp <span style=3D"color: gre=
y">(8fb0608)</span></li>

 <li>kwin/effects/snaphelper/snaphelper.h <span style=3D"color: grey">(ee60=
f8f)</span></li>

 <li>kwin/effects/snaphelper/snaphelper.cpp <span style=3D"color: grey">(a3=
0cc60)</span></li>

 <li>kwin/effects/taskbarthumbnail/taskbarthumbnail.h <span style=3D"color:=
 grey">(77e5294)</span></li>

 <li>kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp <span style=3D"colo=
r: grey">(1ce6233)</span></li>

 <li>kwin/effects/thumbnailaside/thumbnailaside.h <span style=3D"color: gre=
y">(323e2fd)</span></li>

 <li>kwin/effects/thumbnailaside/thumbnailaside.cpp <span style=3D"color: g=
rey">(3a1b4e0)</span></li>

 <li>kwin/effects/translucency/translucency.h <span style=3D"color: grey">(=
fa7b85c)</span></li>

 <li>kwin/effects/translucency/translucency.cpp <span style=3D"color: grey"=
>(4e6d58d)</span></li>

 <li>kwin/effects/windowgeometry/windowgeometry.h <span style=3D"color: gre=
y">(ba20c05)</span></li>

 <li>kwin/effects/windowgeometry/windowgeometry.cpp <span style=3D"color: g=
rey">(a9fd796)</span></li>

 <li>kwin/effects/wobblywindows/wobblywindows.h <span style=3D"color: grey"=
>(d4844d3)</span></li>

 <li>kwin/effects/wobblywindows/wobblywindows.cpp <span style=3D"color: gre=
y">(c7d30fe)</span></li>

 <li>kwin/libkwineffects/kwinanimationeffect.h <span style=3D"color: grey">=
(106155c)</span></li>

 <li>kwin/libkwineffects/kwinanimationeffect.cpp <span style=3D"color: grey=
">(00a7887)</span></li>

 <li>kwin/libkwineffects/kwineffects.h <span style=3D"color: grey">(491ec58=
)</span></li>

 <li>kwin/scripting/scriptedeffect.h <span style=3D"color: grey">(PRE-CREAT=
ION)</span></li>

 <li>kwin/scripting/scriptedeffect.cpp <span style=3D"color: grey">(PRE-CRE=
ATION)</span></li>

 <li>kwin/thumbnailitem.cpp <span style=3D"color: grey">(73441a0)</span></l=
i>

</ul>

<p><a href=3D"http://git.reviewboard.kde.org/r/103823/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============4863444965842245746==--

--===============7092674535466688840==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--===============7092674535466688840==--