'Review Request: removing PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS_WITHOUT_FULL_REPAINTS and some other'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: removing PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS_WITHOUT_FULL_REPAINTS and some other
From:       "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date:       2012-01-29 19:11:52
Message-ID: 20120129191152.23044.51322 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103827/
-----------------------------------------------------------

Review request for kwin.

Description
-------

As the title says it removes \
PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS_WITHOUT_FULL_REPAINTS and handles all of these \
cases now within paintSimpleScreen. Additionally I cleaned up some functions.

The motivation behind this is an increased performance in the affected effects \
(mainly SlidingPopups and TaskbarThumbnail).

For the individual commmits please see here:
http://quickgit.kde.org/index.php?p=clones%2Fkde-workspace%2Fknechtges%2Fpersonal.git&a=shortlog&h=refs/heads/optimizingPaintScreen

Diffs
-----

  kwin/effects/invert/invert.cpp 0ef154520af8d50d4d85a3599a1d7448dfc5a2be 
  kwin/effects/slidingpopups/slidingpopups.cpp \
8fb06080311eb962dc91a55fd600310c1f19ff12   \
kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp \
1ce62332fdef980961f1b58055a2cbb1b75680c3   \
kwin/effects/wobblywindows/wobblywindows.cpp c7d30febc17cb4d1b9b668b7f997ea9310de94df \
  kwin/libkwineffects/kwineffects.h 491ec5850637e6570ee2f0bdb98ebad12b676016 
  kwin/scene.h c2273525223b4754e9a88efbfffc414cf1f6497c 
  kwin/scene.cpp ef1058dfeea4f61c4e19f5fce5ab1d15df941dda 
  kwin/scene_xrender.h c181f0dca9e1ef7c9eb77aad8dd4b291f5056098 
  kwin/scene_xrender.cpp dea424a6e2e21d8fe96bef597ee34e5cc8d6c6a3 

Diff: http://git.reviewboard.kde.org/r/103827/diff/diff

Testing
-------

works

Thanks,

Philipp Knechtges

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103827/">http://git.reviewboard.kde.org/r/103827/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Philipp Knechtges.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As the title says it removes \
PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS_WITHOUT_FULL_REPAINTS and handles all of these \
cases now within paintSimpleScreen. Additionally I cleaned up some functions.

The motivation behind this is an increased performance in the affected effects \
(mainly SlidingPopups and TaskbarThumbnail).

For the individual commmits please see here:
http://quickgit.kde.org/index.php?p=clones%2Fkde-workspace%2Fknechtges%2Fpersonal.git&amp;a=shortlog&amp;h=refs/heads/optimizingPaintScreen</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/invert/invert.cpp <span style="color: \
grey">(0ef154520af8d50d4d85a3599a1d7448dfc5a2be)</span></li>

 <li>kwin/effects/slidingpopups/slidingpopups.cpp <span style="color: \
grey">(8fb06080311eb962dc91a55fd600310c1f19ff12)</span></li>

 <li>kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp <span style="color: \
grey">(1ce62332fdef980961f1b58055a2cbb1b75680c3)</span></li>

 <li>kwin/effects/wobblywindows/wobblywindows.cpp <span style="color: \
grey">(c7d30febc17cb4d1b9b668b7f997ea9310de94df)</span></li>

 <li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(491ec5850637e6570ee2f0bdb98ebad12b676016)</span></li>

 <li>kwin/scene.h <span style="color: \
grey">(c2273525223b4754e9a88efbfffc414cf1f6497c)</span></li>

 <li>kwin/scene.cpp <span style="color: \
grey">(ef1058dfeea4f61c4e19f5fce5ab1d15df941dda)</span></li>

 <li>kwin/scene_xrender.h <span style="color: \
grey">(c181f0dca9e1ef7c9eb77aad8dd4b291f5056098)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: \
grey">(dea424a6e2e21d8fe96bef597ee34e5cc8d6c6a3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103827/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 