[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: dropping several gl(Push|Pop)(Attrib|Matrix) calls
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-01-29 19:08:13
Message-ID: 20120129190813.22735.31750 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103804/#review10206
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Gr=C3=A4=C3=9Flin
On Jan. 27, 2012, 4:37 p.m., Philipp Knechtges wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103804/
> -----------------------------------------------------------
> =
> (Updated Jan. 27, 2012, 4:37 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> This makes kwin in OpenGL2 mode more coherent with kwin_gles.
> Despite some fullscreen effects they should now make the same
> (pure) OpenGL calls.
> =
> =
> Diffs
> -----
> =
> kwin/libkwineffects/kwinglutils.cpp 4102d3f1b4a15b467c79103d3fb1e153345=
906c2 =
> kwin/scene_opengl.cpp 18cbd76a1c8f6abfe1bb5d96c51518498abd99c8 =
> kwin/scene_opengl_glx.cpp d978605bb9ebb60f0e1f9ab20f1bb40e88aed20e =
> kwin/effects/blur/blur.cpp 06c685450d86d008071ceb42b266af138f74e854 =
> kwin/effects/cube/cube.cpp 9b957c29c433187727dafbdbe7a3dcc7760f2d64 =
> kwin/effects/cube/cubeslide.cpp ed1f51875bc8b49ca6a2d281c4cd006ba049de9=
2 =
> kwin/effects/mousemark/mousemark.cpp d8e91d9bae9f8ab04dd82f0269a6a0ea01=
b769c8 =
> kwin/effects/resize/resize.cpp 84bdd7f7dbc99457a0e6df4eefcdffdb31c9342f =
> kwin/effects/showfps/showfps.cpp 5161401f7da4adb182b57fbfc5301d5a2f6b00=
28 =
> kwin/effects/showpaint/showpaint.cpp f689b1c64e2599c3b9a5a8df1142901242=
5b40ab =
> kwin/effects/snaphelper/snaphelper.cpp a30cc60f5037360224e2beda1d30f6a1=
9ebfc41d =
> kwin/effects/startupfeedback/startupfeedback.cpp a0d290be7764a5d155594f=
f4097239ebe7ec813e =
> kwin/effects/trackmouse/trackmouse.cpp ab83c1d56fdea943d47abb0e9be733d4=
5d58c7d3 =
> kwin/effects/zoom/zoom.cpp 4131399462695d02d2ab9b5a787f6d808fa831e3 =
> =
> Diff: http://git.reviewboard.kde.org/r/103804/diff/diff
> =
> =
> Testing
> -------
> =
> Tested the affected effects with nvidia blob in GL1 and GL2 mode.
> kwin_gles hasn't been touched anyway.
> =
> =
> Thanks,
> =
> Philipp Knechtges
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103804/">http://git.reviewboard.kde.org/r/103804/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Martin</p>
<br />
<p>On January 27th, 2012, 4:37 p.m., Philipp Knechtges wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Philipp Knechtges.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2012, 4:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This makes kwin in OpenGL2 mode more coherent with kwin_gles. Despite \
some fullscreen effects they should now make the same (pure) OpenGL calls.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested the affected effects with nvidia blob in GL1 and GL2 mode. \
kwin_gles hasn't been touched anyway.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(4102d3f1b4a15b467c79103d3fb1e153345906c2)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: \
grey">(18cbd76a1c8f6abfe1bb5d96c51518498abd99c8)</span></li>
<li>kwin/scene_opengl_glx.cpp <span style="color: \
grey">(d978605bb9ebb60f0e1f9ab20f1bb40e88aed20e)</span></li>
<li>kwin/effects/blur/blur.cpp <span style="color: \
grey">(06c685450d86d008071ceb42b266af138f74e854)</span></li>
<li>kwin/effects/cube/cube.cpp <span style="color: \
grey">(9b957c29c433187727dafbdbe7a3dcc7760f2d64)</span></li>
<li>kwin/effects/cube/cubeslide.cpp <span style="color: \
grey">(ed1f51875bc8b49ca6a2d281c4cd006ba049de92)</span></li>
<li>kwin/effects/mousemark/mousemark.cpp <span style="color: \
grey">(d8e91d9bae9f8ab04dd82f0269a6a0ea01b769c8)</span></li>
<li>kwin/effects/resize/resize.cpp <span style="color: \
grey">(84bdd7f7dbc99457a0e6df4eefcdffdb31c9342f)</span></li>
<li>kwin/effects/showfps/showfps.cpp <span style="color: \
grey">(5161401f7da4adb182b57fbfc5301d5a2f6b0028)</span></li>
<li>kwin/effects/showpaint/showpaint.cpp <span style="color: \
grey">(f689b1c64e2599c3b9a5a8df11429012425b40ab)</span></li>
<li>kwin/effects/snaphelper/snaphelper.cpp <span style="color: \
grey">(a30cc60f5037360224e2beda1d30f6a19ebfc41d)</span></li>
<li>kwin/effects/startupfeedback/startupfeedback.cpp <span style="color: \
grey">(a0d290be7764a5d155594ff4097239ebe7ec813e)</span></li>
<li>kwin/effects/trackmouse/trackmouse.cpp <span style="color: \
grey">(ab83c1d56fdea943d47abb0e9be733d45d58c7d3)</span></li>
<li>kwin/effects/zoom/zoom.cpp <span style="color: \
grey">(4131399462695d02d2ab9b5a787f6d808fa831e3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103804/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic