'Re: Review Request: [Spring Cleaning] Remove Scene Basic and test effects'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: [Spring Cleaning] Remove Scene Basic and test effects
From:       "Commit Hook" <null () kde ! org>
Date:       2012-01-27 7:20:45
Message-ID: 20120127072045.2088.40369 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103744/#review10119
-----------------------------------------------------------

This review has been submitted with commit 3702ca978e37f5acd850effd75d39ecf=
aa21a14a by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On Jan. 20, 2012, 11:02 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103744/
> -----------------------------------------------------------
> =

> (Updated Jan. 20, 2012, 11:02 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Title says it all: spring cleaning. Removal of code which does not get co=
mpiled, does not get adjusted to latest changes and is just not required an=
y more.
> =

> If nobody brings up a good argument to keep the code, I will drop it in o=
ne week from now. Even after the removal we still have access to it through=
 the git history.
> =

> =

> Diffs
> -----
> =

>   kwin/CMakeLists.txt 65a2aba =

>   kwin/composite.cpp 55a7144 =

>   kwin/effects/CMakeLists.txt a9eea1d =

>   kwin/effects/_test/CMakeLists.txt 3b01508 =

>   kwin/effects/_test/data/liquid.frag f2515fe =

>   kwin/effects/_test/data/liquid.vert 55d169d =

>   kwin/effects/_test/demo_liquid.cpp be2535b =

>   kwin/effects/_test/demo_liquid.desktop 0668430 =

>   kwin/effects/_test/demo_liquid.h 03063d9 =

>   kwin/effects/_test/demo_shakymove.cpp 1b7ff84 =

>   kwin/effects/_test/demo_shakymove.desktop 3b878bb =

>   kwin/effects/_test/demo_shakymove.h 5fc4917 =

>   kwin/effects/_test/demo_shiftworkspaceup.cpp 96498c2 =

>   kwin/effects/_test/demo_shiftworkspaceup.desktop c551c8b =

>   kwin/effects/_test/demo_shiftworkspaceup.h 2de830c =

>   kwin/effects/_test/demo_showpicture.cpp 943b20a =

>   kwin/effects/_test/demo_showpicture.desktop 8cc754b =

>   kwin/effects/_test/demo_showpicture.h 531ea99 =

>   kwin/effects/_test/demo_wavywindows.cpp a0af6d1 =

>   kwin/effects/_test/demo_wavywindows.desktop 11f1bd1 =

>   kwin/effects/_test/demo_wavywindows.h 9b85e27 =

>   kwin/effects/_test/drunken.cpp 3896c0d =

>   kwin/effects/_test/drunken.desktop 2a2c40a =

>   kwin/effects/_test/drunken.h cb14ca5 =

>   kwin/effects/_test/flame.cpp 31328be =

>   kwin/effects/_test/flame.desktop 814ecc1 =

>   kwin/effects/_test/flame.h a93aba3 =

>   kwin/effects/_test/gears.cpp 2c8075e =

>   kwin/effects/_test/gears.desktop 1a95c7f =

>   kwin/effects/_test/gears.h b7e7fbc =

>   kwin/effects/_test/howto.cpp f031dcb =

>   kwin/effects/_test/howto.desktop e8ac8ea =

>   kwin/effects/_test/howto.h ff4eb74 =

>   kwin/effects/_test/kicker/CMakeLists.txt 5fac700 =

>   kwin/effects/_test/kicker/kicker.cpp 227d4ea =

>   kwin/effects/_test/kicker/kicker.desktop dad15fd =

>   kwin/effects/_test/kicker/kicker.h 332d987 =

>   kwin/effects/_test/slidetabs/CMakeLists.txt 230a0d5 =

>   kwin/effects/_test/slidetabs/slidetabs.cpp 0b7061f =

>   kwin/effects/_test/slidetabs/slidetabs.desktop 70f4b6a =

>   kwin/effects/_test/slidetabs/slidetabs.h b79261a =

>   kwin/effects/_test/slidetabs/slidetabs_config.cpp b4c4664 =

>   kwin/effects/_test/slidetabs/slidetabs_config.desktop 5ad9922 =

>   kwin/effects/_test/slidetabs/slidetabs_config.h e0edf41 =

>   kwin/effects/_test/slidetabs/slidetabs_config.ui aba9b49 =

>   kwin/effects/_test/swiveltabs/CMakeLists.txt 6256533 =

>   kwin/effects/_test/swiveltabs/swiveltabs.cpp dd5ad9e =

>   kwin/effects/_test/swiveltabs/swiveltabs.desktop ba63f5f =

>   kwin/effects/_test/swiveltabs/swiveltabs.h 89d3b74 =

>   kwin/effects/_test/swiveltabs/swiveltabs_config.cpp 71f2477 =

>   kwin/effects/_test/swiveltabs/swiveltabs_config.desktop a888372 =

>   kwin/effects/_test/swiveltabs/swiveltabs_config.h 80a7c66 =

>   kwin/effects/_test/swiveltabs/swiveltabs_config.ui 227d7a9 =

>   kwin/effects/_test/test_fbo.cpp eb45637 =

>   kwin/effects/_test/test_fbo.desktop 2ecf3b1 =

>   kwin/effects/_test/test_fbo.h f3bfd66 =

>   kwin/effects/_test/test_input.cpp 7fefbea =

>   kwin/effects/_test/test_input.desktop 9a005cd =

>   kwin/effects/_test/test_input.h 6e4feda =

>   kwin/effects/_test/test_thumbnail.cpp 3017ed3 =

>   kwin/effects/_test/test_thumbnail.desktop 451dce0 =

>   kwin/effects/_test/test_thumbnail.h be11601 =

>   kwin/effects/_test/videorecord.cpp 475ef30 =

>   kwin/effects/_test/videorecord.desktop a40bd7c =

>   kwin/effects/_test/videorecord.h ba72432 =

>   kwin/effects/_test/videorecord_config.cpp 9f11a51 =

>   kwin/effects/_test/videorecord_config.desktop d53fdab =

>   kwin/effects/_test/videorecord_config.h 5563a42 =

>   kwin/scene_basic.h a087eb5 =

>   kwin/scene_basic.cpp cc8dbdd =

> =

> Diff: http://git.reviewboard.kde.org/r/103744/diff/diff
> =

> =

> Testing
> -------
> =

> compiles
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103744/">http://git.reviewboard.kde.org/r/103744/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 3702ca978e37f5acd850effd75d39ecfaa21a14a by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 20th, 2012, 11:02 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2012, 11:02 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Title says it all: spring cleaning. Removal of code which does not get \
compiled, does not get adjusted to latest changes and is just not required any more.

If nobody brings up a good argument to keep the code, I will drop it in one week from \
now. Even after the removal we still have access to it through the git history.</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/CMakeLists.txt <span style="color: grey">(65a2aba)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(55a7144)</span></li>

 <li>kwin/effects/CMakeLists.txt <span style="color: grey">(a9eea1d)</span></li>

 <li>kwin/effects/_test/CMakeLists.txt <span style="color: \
grey">(3b01508)</span></li>

 <li>kwin/effects/_test/data/liquid.frag <span style="color: \
grey">(f2515fe)</span></li>

 <li>kwin/effects/_test/data/liquid.vert <span style="color: \
grey">(55d169d)</span></li>

 <li>kwin/effects/_test/demo_liquid.cpp <span style="color: \
grey">(be2535b)</span></li>

 <li>kwin/effects/_test/demo_liquid.desktop <span style="color: \
grey">(0668430)</span></li>

 <li>kwin/effects/_test/demo_liquid.h <span style="color: grey">(03063d9)</span></li>

 <li>kwin/effects/_test/demo_shakymove.cpp <span style="color: \
grey">(1b7ff84)</span></li>

 <li>kwin/effects/_test/demo_shakymove.desktop <span style="color: \
grey">(3b878bb)</span></li>

 <li>kwin/effects/_test/demo_shakymove.h <span style="color: \
grey">(5fc4917)</span></li>

 <li>kwin/effects/_test/demo_shiftworkspaceup.cpp <span style="color: \
grey">(96498c2)</span></li>

 <li>kwin/effects/_test/demo_shiftworkspaceup.desktop <span style="color: \
grey">(c551c8b)</span></li>

 <li>kwin/effects/_test/demo_shiftworkspaceup.h <span style="color: \
grey">(2de830c)</span></li>

 <li>kwin/effects/_test/demo_showpicture.cpp <span style="color: \
grey">(943b20a)</span></li>

 <li>kwin/effects/_test/demo_showpicture.desktop <span style="color: \
grey">(8cc754b)</span></li>

 <li>kwin/effects/_test/demo_showpicture.h <span style="color: \
grey">(531ea99)</span></li>

 <li>kwin/effects/_test/demo_wavywindows.cpp <span style="color: \
grey">(a0af6d1)</span></li>

 <li>kwin/effects/_test/demo_wavywindows.desktop <span style="color: \
grey">(11f1bd1)</span></li>

 <li>kwin/effects/_test/demo_wavywindows.h <span style="color: \
grey">(9b85e27)</span></li>

 <li>kwin/effects/_test/drunken.cpp <span style="color: grey">(3896c0d)</span></li>

 <li>kwin/effects/_test/drunken.desktop <span style="color: \
grey">(2a2c40a)</span></li>

 <li>kwin/effects/_test/drunken.h <span style="color: grey">(cb14ca5)</span></li>

 <li>kwin/effects/_test/flame.cpp <span style="color: grey">(31328be)</span></li>

 <li>kwin/effects/_test/flame.desktop <span style="color: grey">(814ecc1)</span></li>

 <li>kwin/effects/_test/flame.h <span style="color: grey">(a93aba3)</span></li>

 <li>kwin/effects/_test/gears.cpp <span style="color: grey">(2c8075e)</span></li>

 <li>kwin/effects/_test/gears.desktop <span style="color: grey">(1a95c7f)</span></li>

 <li>kwin/effects/_test/gears.h <span style="color: grey">(b7e7fbc)</span></li>

 <li>kwin/effects/_test/howto.cpp <span style="color: grey">(f031dcb)</span></li>

 <li>kwin/effects/_test/howto.desktop <span style="color: grey">(e8ac8ea)</span></li>

 <li>kwin/effects/_test/howto.h <span style="color: grey">(ff4eb74)</span></li>

 <li>kwin/effects/_test/kicker/CMakeLists.txt <span style="color: \
grey">(5fac700)</span></li>

 <li>kwin/effects/_test/kicker/kicker.cpp <span style="color: \
grey">(227d4ea)</span></li>

 <li>kwin/effects/_test/kicker/kicker.desktop <span style="color: \
grey">(dad15fd)</span></li>

 <li>kwin/effects/_test/kicker/kicker.h <span style="color: \
grey">(332d987)</span></li>

 <li>kwin/effects/_test/slidetabs/CMakeLists.txt <span style="color: \
grey">(230a0d5)</span></li>

 <li>kwin/effects/_test/slidetabs/slidetabs.cpp <span style="color: \
grey">(0b7061f)</span></li>

 <li>kwin/effects/_test/slidetabs/slidetabs.desktop <span style="color: \
grey">(70f4b6a)</span></li>

 <li>kwin/effects/_test/slidetabs/slidetabs.h <span style="color: \
grey">(b79261a)</span></li>

 <li>kwin/effects/_test/slidetabs/slidetabs_config.cpp <span style="color: \
grey">(b4c4664)</span></li>

 <li>kwin/effects/_test/slidetabs/slidetabs_config.desktop <span style="color: \
grey">(5ad9922)</span></li>

 <li>kwin/effects/_test/slidetabs/slidetabs_config.h <span style="color: \
grey">(e0edf41)</span></li>

 <li>kwin/effects/_test/slidetabs/slidetabs_config.ui <span style="color: \
grey">(aba9b49)</span></li>

 <li>kwin/effects/_test/swiveltabs/CMakeLists.txt <span style="color: \
grey">(6256533)</span></li>

 <li>kwin/effects/_test/swiveltabs/swiveltabs.cpp <span style="color: \
grey">(dd5ad9e)</span></li>

 <li>kwin/effects/_test/swiveltabs/swiveltabs.desktop <span style="color: \
grey">(ba63f5f)</span></li>

 <li>kwin/effects/_test/swiveltabs/swiveltabs.h <span style="color: \
grey">(89d3b74)</span></li>

 <li>kwin/effects/_test/swiveltabs/swiveltabs_config.cpp <span style="color: \
grey">(71f2477)</span></li>

 <li>kwin/effects/_test/swiveltabs/swiveltabs_config.desktop <span style="color: \
grey">(a888372)</span></li>

 <li>kwin/effects/_test/swiveltabs/swiveltabs_config.h <span style="color: \
grey">(80a7c66)</span></li>

 <li>kwin/effects/_test/swiveltabs/swiveltabs_config.ui <span style="color: \
grey">(227d7a9)</span></li>

 <li>kwin/effects/_test/test_fbo.cpp <span style="color: grey">(eb45637)</span></li>

 <li>kwin/effects/_test/test_fbo.desktop <span style="color: \
grey">(2ecf3b1)</span></li>

 <li>kwin/effects/_test/test_fbo.h <span style="color: grey">(f3bfd66)</span></li>

 <li>kwin/effects/_test/test_input.cpp <span style="color: \
grey">(7fefbea)</span></li>

 <li>kwin/effects/_test/test_input.desktop <span style="color: \
grey">(9a005cd)</span></li>

 <li>kwin/effects/_test/test_input.h <span style="color: grey">(6e4feda)</span></li>

 <li>kwin/effects/_test/test_thumbnail.cpp <span style="color: \
grey">(3017ed3)</span></li>

 <li>kwin/effects/_test/test_thumbnail.desktop <span style="color: \
grey">(451dce0)</span></li>

 <li>kwin/effects/_test/test_thumbnail.h <span style="color: \
grey">(be11601)</span></li>

 <li>kwin/effects/_test/videorecord.cpp <span style="color: \
grey">(475ef30)</span></li>

 <li>kwin/effects/_test/videorecord.desktop <span style="color: \
grey">(a40bd7c)</span></li>

 <li>kwin/effects/_test/videorecord.h <span style="color: grey">(ba72432)</span></li>

 <li>kwin/effects/_test/videorecord_config.cpp <span style="color: \
grey">(9f11a51)</span></li>

 <li>kwin/effects/_test/videorecord_config.desktop <span style="color: \
grey">(d53fdab)</span></li>

 <li>kwin/effects/_test/videorecord_config.h <span style="color: \
grey">(5563a42)</span></li>

 <li>kwin/scene_basic.h <span style="color: grey">(a087eb5)</span></li>

 <li>kwin/scene_basic.cpp <span style="color: grey">(cc8dbdd)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103744/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 