[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Support withdrawal of shadows
From: "Commit Hook" <null () kde ! org>
Date: 2012-01-24 23:54:41
Message-ID: 20120124235441.2328.551 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103751/#review10064
-----------------------------------------------------------
This review has been submitted with commit c42b7ed8b7abe7e44384a9c59f10eaab53549227 by Thomas \
Lübking to branch master.
- Commit Hook
On Jan. 20, 2012, 11:09 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103751/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2012, 11:09 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> Probably doesn't fix the actual bug, but helps to resolve the conflict (as for the actual \
> bug, i assume it's some gtk+ issue??)
>
> This addresses bug 291774.
> http://bugs.kde.org/show_bug.cgi?id=291774
>
>
> Diffs
> -----
>
> kwin/shadow.cpp b5a7e08
>
> Diff: http://git.reviewboard.kde.org/r/103751/diff/diff
>
>
> Testing
> -------
>
> Yes, timer removed shadows of popups - worked nicely with the patch.
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103751/">http://git.reviewboard.kde.org/r/103751/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
c42b7ed8b7abe7e44384a9c59f10eaab53549227 by Thomas Lübking to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On January 20th, 2012, 11:09 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2012, 11:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Probably doesn't \
fix the actual bug, but helps to resolve the conflict (as for the actual bug, i assume it's \
some gtk+ issue??)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, timer removed \
shadows of popups - worked nicely with the patch.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291774">291774</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/shadow.cpp <span style="color: grey">(b5a7e08)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103751/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic