[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Drop Xinerama related options in KWin
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-01-22 18:29:23
Message-ID: 20120122182923.4495.65074 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 22, 2012, 6:09 p.m., Alex Fiestas wrote:
> > Tested and everything works as expected :) !
just ftr: afaics there's no way for a desktop wall (ie. treating all screen=
s as one) left, is it?
personally i don't mind, but there might have been claims on this at kcd.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103756/#review10000
-----------------------------------------------------------
On Jan. 22, 2012, 10:21 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103756/
> -----------------------------------------------------------
> =
> (Updated Jan. 22, 2012, 10:21 a.m.)
> =
> =
> Review request for kwin and Plasma.
> =
> =
> Description
> -------
> =
> As discussed on the mailinglist: drop of the xinerama related options and=
the kcm. Given that the show unmanaged windows on option is in fact not us=
ed, I dropped the complete KCM.
> =
> =
> Diffs
> -----
> =
> kcontrol/CMakeLists.txt 8cd9a46 =
> kcontrol/xinerama/CMakeLists.txt fe332e5 =
> kcontrol/xinerama/Messages.sh f4aa134 =
> kcontrol/xinerama/interface_util.h 8a4fcd1 =
> kcontrol/xinerama/kcmxinerama.h 18b9241 =
> kcontrol/xinerama/kcmxinerama.cpp a456b2c =
> kcontrol/xinerama/test_kcm_xinerama.cpp a358a2c =
> kcontrol/xinerama/xinerama.desktop e8ce525 =
> kcontrol/xinerama/xineramawidget.h 2c446a2 =
> kcontrol/xinerama/xineramawidget.cpp df9cb2f =
> kcontrol/xinerama/xineramawidget.ui 90ec4d4 =
> kwin/geometry.cpp a414e26 =
> kwin/manage.cpp c551eac =
> kwin/options.h 9dc29cf =
> kwin/options.cpp d496569 =
> kwin/tabbox/tabbox.cpp 3051316 =
> kwin/toplevel.cpp ffe7f0c =
> kwin/workspace.cpp 69b4ecb =
> =
> Diff: http://git.reviewboard.kde.org/r/103756/diff/diff
> =
> =
> Testing
> -------
> =
> Fullscreen: works
> Maximize: works
> Movment: works
> Placement: works
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103756/">http://git.reviewboard.kde.org/r/103756/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 22nd, 2012, 6:09 p.m., <b>Alex \
Fiestas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested and everything works as expected :) !</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just ftr: afaics \
there's no way for a desktop wall (ie. treating all screens as one) left, is it? \
personally i don't mind, but there might have been claims on this at kcd.</pre> \
<br />
<p>- Thomas</p>
<br />
<p>On January 22nd, 2012, 10:21 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2012, 10:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed on the mailinglist: drop of the xinerama related options \
and the kcm. Given that the show unmanaged windows on option is in fact not used, I \
dropped the complete KCM.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fullscreen: works
Maximize: works
Movment: works
Placement: works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/CMakeLists.txt <span style="color: grey">(8cd9a46)</span></li>
<li>kcontrol/xinerama/CMakeLists.txt <span style="color: grey">(fe332e5)</span></li>
<li>kcontrol/xinerama/Messages.sh <span style="color: grey">(f4aa134)</span></li>
<li>kcontrol/xinerama/interface_util.h <span style="color: \
grey">(8a4fcd1)</span></li>
<li>kcontrol/xinerama/kcmxinerama.h <span style="color: grey">(18b9241)</span></li>
<li>kcontrol/xinerama/kcmxinerama.cpp <span style="color: \
grey">(a456b2c)</span></li>
<li>kcontrol/xinerama/test_kcm_xinerama.cpp <span style="color: \
grey">(a358a2c)</span></li>
<li>kcontrol/xinerama/xinerama.desktop <span style="color: \
grey">(e8ce525)</span></li>
<li>kcontrol/xinerama/xineramawidget.h <span style="color: \
grey">(2c446a2)</span></li>
<li>kcontrol/xinerama/xineramawidget.cpp <span style="color: \
grey">(df9cb2f)</span></li>
<li>kcontrol/xinerama/xineramawidget.ui <span style="color: \
grey">(90ec4d4)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(a414e26)</span></li>
<li>kwin/manage.cpp <span style="color: grey">(c551eac)</span></li>
<li>kwin/options.h <span style="color: grey">(9dc29cf)</span></li>
<li>kwin/options.cpp <span style="color: grey">(d496569)</span></li>
<li>kwin/tabbox/tabbox.cpp <span style="color: grey">(3051316)</span></li>
<li>kwin/toplevel.cpp <span style="color: grey">(ffe7f0c)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(69b4ecb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103756/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic