From kwin Fri Jan 20 12:26:12 2012 From: Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= Date: Fri, 20 Jan 2012 12:26:12 +0000 To: kwin Subject: Re: Re: [RFC] Remove Xinerama related options Message-Id: <8057888.MiYQDjYBU0 () martin-desktop> X-MARC-Message: https://marc.info/?l=kwin&m=132706257009425 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8126833829345434522==" --===============8126833829345434522== Content-Type: multipart/signed; boundary="nextPart9230796.37zD5IzVSl"; micalg="pgp-sha1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7Bit --nextPart9230796.37zD5IzVSl Content-Type: multipart/alternative; boundary="nextPart2528461.0bj4BEibuX" Content-Transfer-Encoding: 7Bit --nextPart2528461.0bj4BEibuX Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Friday 20 January 2012 13:09:18 Xavier IZARD wrote: > Martin Gr=C3=A4=C3=9Flin a =C3=A9crit : > > Hi workspace developers, > >=20 > > KWin provides the option to turn off multi screen aware window mana= gement. > > This results in windows being maximized over both screens or fullsc= reen > > windows being stretched over all screens. These options make the co= de much > > more complex and add confusing configuration dialogs to our workspa= ce (see > > attached screenshot). > >=20 > > Example code: > > int Workspace::numScreens() const > > { > >=20 > > if (!options->xineramaEnabled) > > =20 > > return 1; > > =20 > > return Kephal::ScreenUtils::numScreens(); > >=20 > > } > >=20 > > I personally fail to understand why the options are needed and why = they > > have been added in the first place. With git blame I was not able t= o go > > back so far in the history to find when they were added. Note: the > > xinerama code used also to be ifdefed, so I could imagine it being = from a > > time back when multi screens was a new feature. > >=20 > >> From the userinterface the only useful option is "Show unmanaged w= indows > >> on">=20 > > which should be kept. All other options make in my opinion just no = sense. > >=20 > > If nobody sees any good reason to keep these options I would prepar= e the > > removal. > >=20 > > The reason is btw not to remove options, but to decrease the comple= xity of > > the code as shown above and the fact that it is a break my system s= etting > > which happened more than once that users complained about maximize = not > > working any more. > >=20 > > Cheers > > Martin >=20 > Hi, >=20 >=20 > Could be more clear about the behaviour of kwin without these options= ? >=20 > I suppose that the behaviour would be the same as when all these opti= ons > were checked ? (ie, maximize & fullscreen work on each screen > independently, magnetic borders, ...) yes, everything would be like the options are checked >=20 > What about persons who group monitors to do a huge monitor panel ? > (video wall). > What about people who use very large monitor needing dual video input= s ? those can disable xinerama support through xorg.conf >=20 >=20 > My personal usage is (was) this one : I uncheck the option "Enable > multiple monitor window fullscreen support" (all other options are > checked). So that : > -> When working on my computer, the maximized windows spawn only one > monitor at a time, I get magnetic borders, ... > -> When watching movie (fullscreen mode), the display spawns all my > monitors thus doing a video wall. so you would only need one of the options, the fullscreen one? And in f= act you=20 only want that for vlc, right? You don't want the option for let's say=20= Firefox? So e.g. a KWin script taking care of setting the fullscreen video playe= r to=20 all screens would suit you better, right? >=20 >=20 > Sorry, but what I see here is a powerful feature of KDE that is going= to > disappear ... >=20 >=20 > Regards, > Xavier >=20 > P.S. I am the "author" of the option "Enable multiple monitor window > fullscreen support" Thanks for providing your feedback. This is appreciated and quite helpf= ull. Cheers Martin --nextPart2528461.0bj4BEibuX Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"

On = Friday 20 January 2012 13:09:18 Xavier IZARD wrote:

>= ; Martin Gr=C3=A4=C3=9Flin a =C3=A9crit :

>= ; > Hi workspace developers,

>= ; >

>= ; > KWin provides the option to turn off multi screen aware window m= anagement.

>= ; > This results in windows being maximized over both screens or ful= lscreen

>= ; > windows being stretched over all screens. These options make the= code much

>= ; > more complex and add confusing configuration dialogs to our work= space (see

>= ; > attached screenshot).

>= ; >

>= ; > Example code:

>= ; > int Workspace::numScreens() const

>= ; > {

>= ; >

>= ; > if (!options->xineramaEnabled)

>= ; >

>= ; > return 1;

>= ; >

>= ; > return Kephal::ScreenUtils::numScreens();

>= ; >

>= ; > }

>= ; >

>= ; > I personally fail to understand why the options are needed and w= hy they

>= ; > have been added in the first place. With git blame I was not abl= e to go

>= ; > back so far in the history to find when they were added. Note: t= he

>= ; > xinerama code used also to be ifdefed, so I could imagine it bei= ng from a

>= ; > time back when multi screens was a new feature.

>= ; >

>= ; >> From the userinterface the only useful option is "Show = unmanaged windows

>= ; >> on">

>= ; > which should be kept. All other options make in my opinion just = no sense.

>= ; >

>= ; > If nobody sees any good reason to keep these options I would pre= pare the

>= ; > removal.

>= ; >

>= ; > The reason is btw not to remove options, but to decrease the com= plexity of

>= ; > the code as shown above and the fact that it is a break my syste= m setting

>= ; > which happened more than once that users complained about maximi= ze not

>= ; > working any more.

>= ; >

>= ; > Cheers

>= ; > Martin

>= ;

>= ; Hi,

>= ;

>= ; Could be more clear about the behaviour of kwin without these options= ?

>= ;

>= ; I suppose that the behaviour would be the same as when all these opti= ons

>= ; were checked ? (ie, maximize & fullscreen work on each screen

>= ; independently, magnetic borders, ...)

yes= , everything would be like the options are checked

>= ;

>= ; What about persons who group monitors to do a huge monitor panel ?

>= ; (video wall).

>= ; What about people who use very large monitor needing dual video input= s ?

tho= se can disable xinerama support through xorg.conf

>= ;

>= ; My personal usage is (was) this one : I uncheck the option "Enab= le

>= ; multiple monitor window fullscreen support" (all other options a= re

>= ; checked). So that :

>= ; -> When working on my computer, the maximized windows spawn only o= ne

>= ; monitor at a time, I get magnetic borders, ...

>= ; -> When watching movie (fullscreen mode), the display spawns all m= y

>= ; monitors thus doing a video wall.

so = you would only need one of the options, the fullscreen one? And in fact= you only want that for vlc, right? You don't want the option for let's= say Firefox?

So = e.g. a KWin script taking care of setting the fullscreen video player t= o all screens would suit you better, right?

>= ;

>= ; Sorry, but what I see here is a powerful feature of KDE that is going= to

>= ; disappear ...

>= ;

>= ; Regards,

>= ; Xavier

>= ;

>= ; P.S. I am the "author" of the option "Enable multiple = monitor window

>= ; fullscreen support"

Tha= nks for providing your feedback. This is appreciated and quite helpfull= .

Che= ers

Mar= tin

--nextPart2528461.0bj4BEibuX-- --nextPart9230796.37zD5IzVSl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEUEABECAAYFAk8ZXWQACgkQqVXwidMiVrpFCgCghaJkGmX0xU9LsY3JRDAFjjlk TXIAl10s7WpoMCba4GtPUa2g2O4B1xU= =dfxN -----END PGP SIGNATURE----- --nextPart9230796.37zD5IzVSl-- --===============8126833829345434522== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============8126833829345434522==--