From kwin Mon Jan 16 11:57:35 2012 From: "Philipp Knechtges" Date: Mon, 16 Jan 2012 11:57:35 +0000 To: kwin Subject: Review Request: ensure that slidingpopups always ends Message-Id: <20120116115735.24288.86737 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=132671522631033 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0053208150010840955==" --===============0053208150010840955== Content-Type: multipart/alternative; boundary="===============3623692736639913115==" --===============3623692736639913115== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103705/ ----------------------------------------------------------- Review request for kwin and Martin Gr=C3=A4=C3=9Flin. Description ------- It was reported that the slidingPopups effect still faces the high CPU usag= e issue. Although I cannot reproduce the issue I assume it is related to the assumpt= ion of QEasingCurve::valueForProgress(1.0) returning 1.0. Hence the patch repla= ces the test for progress !=3D 1.0 with a general test how much time has elapsed. This addresses bugs 288948 and 290025. http://bugs.kde.org/show_bug.cgi?id=3D288948 http://bugs.kde.org/show_bug.cgi?id=3D290025 Diffs ----- kwin/effects/slidingpopups/slidingpopups.cpp 8fb06080311eb962dc91a55fd600= 310c1f19ff12 = Diff: http://git.reviewboard.kde.org/r/103705/diff/diff Testing ------- The effect still works. = Thanks, Philipp Knechtges --===============3623692736639913115== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103705/

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Philipp Knechtges.

Descripti= on 

It was reported that the slidingPopups effect still faces th=
e high CPU usage issue.
Although I cannot reproduce the issue I assume it is related to the assumpt=
ion
of QEasingCurve::valueForProgress(1.0) returning 1.0. Hence the patch repla=
ces the
test for progress !=3D 1.0 with a general test how much time has elapsed.

Testing <= /h1> 
The effect still works.
Bugs: 288948, = 290025

Diffs=

  • kwin/effects/slidingpopups/slidingpopups.cpp (8fb06080311eb962dc91a55fd600310c1f19ff12)

View Diff
--===============3623692736639913115==-- --===============0053208150010840955== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============0053208150010840955==--