From kwin Fri Jan 13 15:43:22 2012 From: "Commit Hook" Date: Fri, 13 Jan 2012 15:43:22 +0000 To: kwin Subject: Re: Review Request: Rank rules above motif Message-Id: <20120113154322.6664.91593 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=132646957831884 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2721706415583539715==" --===============2721706415583539715== Content-Type: multipart/alternative; boundary="===============2647181085938835626==" --===============2647181085938835626== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103681/#review9802 ----------------------------------------------------------- This review has been submitted with commit 5bd9f28ec11e2b59edaa20d9ab9f076a= 87464c5c by Thomas L=C3=BCbking to branch master. - Commit Hook On Jan. 12, 2012, 5:11 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103681/ > ----------------------------------------------------------- > = > (Updated Jan. 12, 2012, 5:11 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > Turns out KDE/Qt application re-yell "have a border" every now and then w= henever they feel like. > The patch > a) ensures that clients may change their opinion, but yelling "MAKE BORDE= R" over and over again, overriding the users (temp. eg. alt+f3 or apply ini= tially rule) is ignored > b) honors rules when applying motif hints (this alone would only cover th= e "force" rules) > = > = > This addresses bug 291312. > http://bugs.kde.org/show_bug.cgi?id=3D291312 > = > = > Diffs > ----- > = > kwin/client.cpp 8c00249 = > = > Diff: http://git.reviewboard.kde.org/r/103681/diff/diff > = > = > Testing > ------- > = > No, I just sensed this would be the issue and happily assume it will work= ... :-P > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============2647181085938835626== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103681/ 

This revie=
w has been submitted with commit 5bd9f28ec11e2b59edaa20d9ab9f076a87464c5c b=
y Thomas L=C3=BCbking to branch master.

- Commit


On January 12th, 2012, 5:11 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated Jan. 12, 2012, 5:11 p.m.

Descripti= on 

Turns out KDE/Qt application re-yell "have a border&quo=
t; every now and then whenever they feel like.
The patch
a) ensures that clients may change their opinion, but yelling "MAKE BO=
RDER" over and over again, overriding the users (temp. eg. alt+f3 or a=
pply initially rule) is ignored
b) honors rules when applying motif hints (this alone would only cover the =
"force" rules)

Testing <= /h1> 
No, I just sensed this would be the issue and happily assume=
 it will work... :-P
Bugs: 291312

Diffs=

  • kwin/client.cpp (8c00249)

View Diff
--===============2647181085938835626==-- --===============2721706415583539715== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2721706415583539715==--