[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Rank rules above motif
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-01-13 14:47:37
Message-ID: 20120113144737.31991.40911 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 12, 2012, 5:14 p.m., Thomas Lübking wrote:
> > kwin/client.cpp, lines 1991-1994
> > <http://git.reviewboard.kde.org/r/103681/diff/2/?file=46525#file46525line1991>
> >
> > This statement breaks re-adding the titlebar to chromium, btw (because it's
> > a) still shaped at this time
> > b) app_noborder is apparently not reset when the shape is withdrawn?
> >
> > We should figure whether "app_noborder" is merely \
> > "noborder_because_shaped_or_window_type" (seems so) and decide whether to still \
> > allow motif hints to override this.
>
> Martin Gräßlin wrote:
> I wouldn't mind removing support for this motif hint. Application developers had \
> enough time to port away from it, although there has not been a real alternative...
Guess what - opera12 theming startd to act like chromium (including the shape \
issue...) :-\
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103681/#review9774
-----------------------------------------------------------
On Jan. 12, 2012, 5:11 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103681/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2012, 5:11 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> Turns out KDE/Qt application re-yell "have a border" every now and then whenever \
> they feel like. The patch
> a) ensures that clients may change their opinion, but yelling "MAKE BORDER" over \
> and over again, overriding the users (temp. eg. alt+f3 or apply initially rule) is \
> ignored b) honors rules when applying motif hints (this alone would only cover the \
> "force" rules)
>
> This addresses bug 291312.
> http://bugs.kde.org/show_bug.cgi?id=291312
>
>
> Diffs
> -----
>
> kwin/client.cpp 8c00249
>
> Diff: http://git.reviewboard.kde.org/r/103681/diff/diff
>
>
> Testing
> -------
>
> No, I just sensed this would be the issue and happily assume it will work... :-P
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103681/">http://git.reviewboard.kde.org/r/103681/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 12th, 2012, 5:14 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103681/diff/2/?file=46525#file46525line1991" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/client.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Client::sl_activated()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1991</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">noborder</span> <span class="o">=</span> <span class="kc">true</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">1991</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">noborder</span> \
<span class="o">=</span> <span class="n"><span class="hl">rules</span></span><span \
class="p"><span class="hl">()</span></span><span class="o"><span \
class="hl">-></span></span><span class="n"><span \
class="hl">checkNoBorder</span></span><span class="p"><span \
class="hl">(</span></span><span class="kc">true</span><span class="p"><span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1992</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// If \
the Motif hint is now telling us to show decorations, we only do so if the app \
didn't</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">1992</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="c1">// If the Motif hint is \
now telling us to show decorations, we only do so if the app \
didn't</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1993</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// \
instruct us to hide decorations in some other way, though.</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1993</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// instruct us to hide decorations in some other way, \
though.</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1994</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">else</span> <span class="k">if</span> <span class="p">(</span><span \
class="o">!</span><span class="n"><span class="hl">motif_noborder</span></span><span \
class="hl"> </span><span class="o"><span class="hl">&&</span></span><span \
class="hl"> </span><span class="o"><span class="hl">!</span></span><span \
class="n">app_noborder</span><span class="p">)</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1994</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">else</span> <span class="k">if</span> <span class="p">(</span><span \
class="o">!</span><span class="n">app_noborder</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This statement breaks \
re-adding the titlebar to chromium, btw (because it's a) still shaped at this \
time b) app_noborder is apparently not reset when the shape is withdrawn?
We should figure whether "app_noborder" is merely \
"noborder_because_shaped_or_window_type" (seems so) and decide whether to \
still allow motif hints to override this.</pre> </blockquote>
<p>On January 13th, 2012, 2:45 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wouldn't mind \
removing support for this motif hint. Application developers had enough time to port \
away from it, although there has not been a real alternative...</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Guess what \
- opera12 theming startd to act like chromium (including the shape issue...) \
:-\</pre> <br />
<p>- Thomas</p>
<br />
<p>On January 12th, 2012, 5:11 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2012, 5:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Turns out KDE/Qt application re-yell "have a border" every now \
and then whenever they feel like. The patch
a) ensures that clients may change their opinion, but yelling "MAKE BORDER" \
over and over again, overriding the users (temp. eg. alt+f3 or apply initially rule) \
is ignored b) honors rules when applying motif hints (this alone would only cover the \
"force" rules)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No, I just sensed this would be the issue and happily assume it will \
work... :-P</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291312">291312</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(8c00249)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103681/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic