From kwin Wed Jan 11 17:09:48 2012 From: "Commit Hook" Date: Wed, 11 Jan 2012 17:09:48 +0000 To: kwin Subject: Re: Review Request: simplifying paintSimpleScreen Message-Id: <20120111170948.29202.74167 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=132630195716816 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2235692275931922677==" --===============2235692275931922677== Content-Type: multipart/alternative; boundary="===============7922266270801110624==" --===============7922266270801110624== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103671/#review9753 ----------------------------------------------------------- This review has been submitted with commit 7a8398f80ec0aa67ed1102cded2bbb45= d7736ecb by Philipp Knechtges to branch master. - Commit Hook On Jan. 10, 2012, 9:08 p.m., Philipp Knechtges wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103671/ > ----------------------------------------------------------- > = > (Updated Jan. 10, 2012, 9:08 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > This patch reduces the number of QRegion and WindowQuadList operations > by drawing the opaque and translucent parts of the window within the > same bottom to top pass. > = > One could also consider removing PAINT_DECORATION_ONLY. Opinions on that? > = > = > Diffs > ----- > = > kwin/libkwineffects/kwineffects.h 780cc89 = > kwin/scene.h d8bcf48 = > kwin/scene.cpp 82935c2 = > kwin/scene_opengl.cpp d85e393 = > kwin/scene_xrender.cpp f76cf70 = > = > Diff: http://git.reviewboard.kde.org/r/103671/diff/diff > = > = > Testing > ------- > = > works :) > = > = > Thanks, > = > Philipp Knechtges > = > --===============7922266270801110624== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103671/ 

This revie=
w has been submitted with commit 7a8398f80ec0aa67ed1102cded2bbb45d7736ecb b=
y Philipp Knechtges to branch master.

- Commit


On January 10th, 2012, 9:08 p.m., Philipp Knechtges wrote:

Review request for kwin.
By Philipp Knechtges.

Updated Jan. 10, 2012, 9:08 p.m.

Descripti= on 

This patch reduces the number of QRegion and WindowQuadList =
operations
by drawing the opaque and translucent parts of the window within the
same bottom to top pass.

One could also consider removing PAINT_DECORATION_ONLY. Opinions on that?

Testing <= /h1> 
works :)

Diffs=

  • kwin/libkwineffects/kwineffects.h (780cc89= )
  • kwin/scene.h (d8bcf48)
  • kwin/scene.cpp (82935c2)
  • kwin/scene_opengl.cpp (d85e393)
  • kwin/scene_xrender.cpp (f76cf70)

View Diff
--===============7922266270801110624==-- --===============2235692275931922677== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2235692275931922677==--