'Review Request: working animations in diminactive'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: working animations in diminactive
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2012-01-11 15:37:50
Message-ID: 20120111153750.23460.68152 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103676/
-----------------------------------------------------------

Review request for kwin.

Description
-------

use a different timeline for each window, letting for independent fade anim=
ations (needed when the active window switches quickly).

issue found:
windowActivated() is emitted two times on each window switch, making the ef=
fect believe there is no active window for a moment, breaking the dim/highl=
ight of window groups.
is it an intended behavior?
only way around i know is doing event compression for that signal, so we re=
act only to the final coherent state.

Diffs
-----

  kwin/effects/diminactive/diminactive.h 24a80de =

  kwin/effects/diminactive/diminactive.cpp 6978f36 =

Diff: http://git.reviewboard.kde.org/r/103676/diff/diff

Testing
-------

Thanks,

Marco Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103676/">http://git.reviewboard.kde.org/r/103676/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Marco Martin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">use a different timeline for each window, letting for independent fade \
animations (needed when the active window switches quickly).

issue found:
windowActivated() is emitted two times on each window switch, making the effect \
believe there is no active window for a moment, breaking the dim/highlight of window \
groups. is it an intended behavior?
only way around i know is doing event compression for that signal, so we react only \
to the final coherent state. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/diminactive/diminactive.h <span style="color: \
grey">(24a80de)</span></li>

 <li>kwin/effects/diminactive/diminactive.cpp <span style="color: \
grey">(6978f36)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103676/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 