This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103655/

Review request for kwin.
By Philipp Knechtges.

Description

This RR is based on 4 commits:
* This first patch allows us to track the GLTexture wrapmode internally.
* The second patch improves the texture update handling:
  It changes the behavior of strictly bound textures such that
  they are only updated if the corresponding window has been damaged.
  Additionally GLTexture now keeps track of the current filter setting.
* The third patch avoids unnecessary texture binds within performPaint.
* The last patch cleans up the GLTexture API.

Testing

nvidia blob works with QT_GRAPHICSSYSTEM=raster/native and GL2/GL1.
Would be nice if somebody could test it with hardware which really requires the strict texture binding.

Diffs

  • kwin/libkwineffects/kwingltexture.h (6795d0dbf1f9a8d6359a234ceac6ab1c6aa27a0b)
  • kwin/libkwineffects/kwingltexture.cpp (4155fb16f35d256a326111e8c1ab7998f36026e6)
  • kwin/libkwineffects/kwingltexture_p.h (7e04305a92f29ac8b7b7e662d7c5f4f6935c0fc3)
  • kwin/scene_opengl.h (9c0b057f96736eb63704a8cc6116db2df96a5258)
  • kwin/scene_opengl.cpp (d85e39383033323914c8dc96700e5c80bfcec063)
  • kwin/scene_opengl_egl.cpp (dbda7816a730a5408482181aa03cf403b9c5c9b5)
  • kwin/scene_opengl_glx.cpp (84e7f610fed010d538b4a8db82e0d50d31aa8e23)

View Diff