--===============5782885674069341141== Content-Type: multipart/alternative; boundary="===============4710435296320587284==" --===============4710435296320587284== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103567/ ----------------------------------------------------------- (Updated Jan. 4, 2012, 5:35 p.m.) Review request for kwin. Changes ------- * rebased on current master (no parent diff needed) * use invokeMethod for closeWindow Description ------- EffectWindow becomes a QObject and make use of properties in EffectWindow w= here possible instead of inheritance = If possible use the property to Toplevel or Client instead of the pure virt= ual methods. This makes it easier to get a stable ABI. Adding new methods t= o the class no longer requires to add a pure virtual method. = From a performance point of view this change should not matter. Most Effect= Window methods are not invoked during the repaint chain. But only in respon= se to an event like a window got added. There the overhead does not really = matter as well the previous implementation made strong use of dynamic casts= which are also not knwon for being very fast. Some virtuals are still there and should be removed. E.g. isManaged needs a= new method and property in Toplevel. Some other virtuals will stay - e.g. = addRepaint. Some virtuals should go into a d-pointer: e.g setData and data. Diffs (updated) ----- kwin/composite.cpp 55a7144 = kwin/effects.h f4ad2fb = kwin/effects.cpp 6c252c9 = kwin/libkwineffects/kwineffects.h 780cc89 = kwin/libkwineffects/kwineffects.cpp 1ad53bc = Diff: http://git.reviewboard.kde.org/r/103567/diff/diff Testing ------- tested some effects, properties in general tested through kwin scripting Thanks, Martin Gr=C3=A4=C3=9Flin --===============4710435296320587284== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103567/

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Updated Jan. 4, 2012, 5:35 p.m.

Changes 
* rebased on current master (no parent diff needed)
* use invokeMethod for closeWindow

Descripti= on 

EffectWindow becomes a QObject and make use of properties in=
 EffectWindow where possible instead of inheritance
    =

If possible use the property to Toplevel or Client instead of the pure virt=
ual methods. This makes it easier to get a stable ABI. Adding new methods t=
o the class no longer requires to add a pure virtual method.
    =

From a performance point of view this change should not matter. Most Effect=
Window methods are not invoked during the repaint chain. But only in respon=
se to an event like a window got added. There the overhead does not really =
matter as well the previous implementation made strong use of dynamic casts=
 which are also not knwon for being very fast.

Some virtuals are still there and should be removed. E.g. isManaged needs a=
 new method and property in Toplevel. Some other virtuals will stay - e.g. =
addRepaint. Some virtuals should go into a d-pointer: e.g setData and data.=

Testing <= /h1> 
tested some effects, properties in general tested through kw=
in scripting

Diffs= (updated)

  • kwin/composite.cpp (55a7144)
  • kwin/effects.h (f4ad2fb)
  • kwin/effects.cpp (6c252c9)
  • kwin/libkwineffects/kwineffects.h (780cc89= )
  • kwin/libkwineffects/kwineffects.cpp (1ad53= bc)

View Diff
--===============4710435296320587284==-- --===============5782885674069341141== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============5782885674069341141==--