[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Tabbing bug - once more
From: "Commit Hook" <null () kde ! org>
Date: 2012-01-02 18:23:03
Message-ID: 20120102182303.27232.75599 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103612/#review9470
-----------------------------------------------------------
This review has been submitted with commit 7b3df4a02ecb0d234ea4567441d0d686a000a9a1 \
by Thomas Lübking to branch KDE/4.8.
- Commit Hook
On Jan. 2, 2012, 4:06 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103612/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2012, 4:06 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> Looking at the code, it was obvious this wouldn't work.
> To reproduce the crash you must rulefix one window to a certain desktop, group it \
> with another one and move that other one to another desktop.
> This will break the group (good) and crash kwin (not so good), because
> a) no const iterators if one intends to manipulate the list
> b) manipulating the list is to be done using "it == list.erase(it);" omitting the \
> "++it") - freaking around in the list under the iterators will always successfully \
> crash
> Unfortunately non of the authors seems to have a reviewboard account...
>
>
> This addresses bug 290387.
> http://bugs.kde.org/show_bug.cgi?id=290387
>
>
> Diffs
> -----
>
> kwin/clientgroup.cpp abf6e63
>
> Diff: http://git.reviewboard.kde.org/r/103612/diff/diff
>
>
> Testing
> -------
>
> Yes. Crashed, fixed, failed to crash - at least in this function :-(
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103612/">http://git.reviewboard.kde.org/r/103612/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7b3df4a02ecb0d234ea4567441d0d686a000a9a1 by Thomas Lübking to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On January 2nd, 2012, 4:06 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 2, 2012, 4:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looking at the code, it was obvious this wouldn't work. To reproduce \
the crash you must rulefix one window to a certain desktop, group it with another one \
and move that other one to another desktop.
This will break the group (good) and crash kwin (not so good), because
a) no const iterators if one intends to manipulate the list
b) manipulating the list is to be done using "it == list.erase(it);" \
omitting the "++it") - freaking around in the list under the iterators will \
always successfully crash
Unfortunately non of the authors seems to have a reviewboard account...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes. Crashed, fixed, failed to crash - at least in this function \
:-(</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=290387">290387</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clientgroup.cpp <span style="color: grey">(abf6e63)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103612/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic