[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add support for graphicssystem selection
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-01-02 17:00:04
Message-ID: 20120102170004.17210.50744 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103430/#review9458
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Gräßlin
On Dec. 28, 2011, 10:47 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103430/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2011, 10:47 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> As discussed, the performance of the raster graphicssystem on the xrender backend \
> is -independent of the decoration- lousy on at least nvidia and intel and likely \
> anywhere else. On the other hand, several decos have a strong preference for the \
> raster system (probably because of QGradient defects - no, not fixable upstream. \
> driver issue. code is there but not used ...)
> The patch allows to configure the system (stronger than QT_GRAPHICSSYSTEM \
> environment or qmake variable, but weaker than --graphicssystem) and also \
> preselects "native" when xrender is used and raster is not explicitly selected.
> For this purpose the patch also writes back the compositing backend on fallback for \
> OpenGL issues.
>
> This addresses bug 289904.
> http://bugs.kde.org/show_bug.cgi?id=289904
>
>
> Diffs
> -----
>
> kwin/composite.cpp 8c793ea
> kwin/libkwineffects/kwinglobals.cpp 69fc99a
> kwin/main.cpp 3773063
> kwin/workspace.h 6069324
> kwin/workspace.cpp 3c67ae6
>
> Diff: http://git.reviewboard.kde.org/r/103430/diff/diff
>
>
> Testing
> -------
>
> Yes:
> - broke my OpenGL ("yes, have sw rasterizer" ;-) and let me run into xrender \
> failsafe with preconfigured raster system
> - removed graphicssystem config and started kwin on xrender with \
> QT_GRAPHICSSYSTEM=raster, successfully ignored
> - swapped graphicssystems and backend in all possible configs, see kcm patch
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103430/">http://git.reviewboard.kde.org/r/103430/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Martin</p>
<br />
<p>On December 28th, 2011, 10:47 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2011, 10:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed, the performance of the raster graphicssystem on the \
xrender backend is -independent of the decoration- lousy on at least nvidia and intel \
and likely anywhere else. On the other hand, several decos have a strong preference \
for the raster system (probably because of QGradient defects - no, not fixable \
upstream. driver issue. code is there but not used ...)
The patch allows to configure the system (stronger than QT_GRAPHICSSYSTEM environment \
or qmake variable, but weaker than --graphicssystem) and also preselects \
"native" when xrender is used and raster is not explicitly selected.
For this purpose the patch also writes back the compositing backend on fallback for \
OpenGL issues.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes:
- broke my OpenGL ("yes, have sw rasterizer" ;-) and let me run into \
xrender failsafe with preconfigured raster system
- removed graphicssystem config and started kwin on xrender with \
QT_GRAPHICSSYSTEM=raster, successfully ignored
- swapped graphicssystems and backend in all possible configs, see kcm patch</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289904">289904</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(8c793ea)</span></li>
<li>kwin/libkwineffects/kwinglobals.cpp <span style="color: \
grey">(69fc99a)</span></li>
<li>kwin/main.cpp <span style="color: grey">(3773063)</span></li>
<li>kwin/workspace.h <span style="color: grey">(6069324)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(3c67ae6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103430/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic