[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Integrate Plasma Scripting Console with KWin
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-12-23 17:54:24
Message-ID: 20111223175424.31142.54071 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 23, 2011, 5:40 p.m., Aaron J. Seigo wrote:
> > looks quite straightforward. i'm not overly fond of having "wm console"=
and "desktop console" and not being able to switch between them in the UI.=
it would be very cool to have the ability to switch modes from the toolbar=
. =
> > =
> > what would be FANTASTIC is to be able to put blocks of plasma-desktop a=
nd kwin code in the same editor and have it run the JS in the "right" place=
, but i think that faces a number of limitations due to the nature of contr=
olling an out of process app (kwin). either the kwin API would need to impl=
emented in plasmagenericshell's scripting and in there forward calls on via=
DBus (or whatever) or limit it rather unnaturally to blocks of code that w=
ould get executed in their own context (e.g. no variables available from bo=
th a desktop block and a kwin block)
> > =
> > so that seems like something for another day, as it would be quite a bi=
t of work :)
> > =
> > imho, for now this can go in as-is with the addition of a drop down in =
the toolbar to switch between modes easily
> it would be very cool to have the ability to switch modes from the toolba=
r. =
Yes, that's something I want to add. I thought about to Toggle Buttons in t=
he toolbar "Plasma", "KWin" which are mutual exclusive. I just didn't want =
to work on it any more today and wanted to push out the review request :-)
Will implement that after Christmas break :-)
The other idea sounds complicated. Not sure whether that would be possible =
at all without exposing complete KWin internals to D-Bus.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103518/#review9210
-----------------------------------------------------------
On Dec. 23, 2011, 2:24 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103518/
> -----------------------------------------------------------
> =
> (Updated Dec. 23, 2011, 2:24 p.m.)
> =
> =
> Review request for kwin and Plasma.
> =
> =
> Description
> -------
> =
> * KWin scripting becomes partly controllable through D-Bus
> * Desktop Scripting Console can control KWin scripts. For that two new me=
thods to PlasmaApp's D-Bus interface are added. If in KWin mode the script =
is passed to KWin through D-Bus
> * Plasma Desktop Runner gains new keyword "wm console" to start Desktop S=
cripting Console in KWin mode.
> =
> =
> Diffs
> -----
> =
> kwin/scripting/scripting.h b0d00f9 =
> kwin/scripting/scripting.cpp 0a71849 =
> plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.h 227748d =
> plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.cpp 617bc69 =
> plasma/desktop/shell/dbus/org.kde.plasma.App.xml e9b6482 =
> plasma/desktop/shell/interactiveconsole.h f94b997 =
> plasma/desktop/shell/interactiveconsole.cpp 6f2ff75 =
> plasma/desktop/shell/plasmaapp.h 3c7289c =
> plasma/desktop/shell/plasmaapp.cpp b630225 =
> =
> Diff: http://git.reviewboard.kde.org/r/103518/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> Desktop Scripting console with KWin integration
> http://git.reviewboard.kde.org/r/103518/s/379/
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103518/">http://git.reviewboard.kde.org/r/103518/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 23rd, 2011, 5:40 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looks quite straightforward. i'm not overly fond of having "wm \
console" and "desktop console" and not being able to switch between \
them in the UI. it would be very cool to have the ability to switch modes from the \
toolbar.
what would be FANTASTIC is to be able to put blocks of plasma-desktop and kwin code \
in the same editor and have it run the JS in the "right" place, but i think \
that faces a number of limitations due to the nature of controlling an out of process \
app (kwin). either the kwin API would need to implemented in plasmagenericshell's \
scripting and in there forward calls on via DBus (or whatever) or limit it rather \
unnaturally to blocks of code that would get executed in their own context (e.g. no \
variables available from both a desktop block and a kwin block)
so that seems like something for another day, as it would be quite a bit of work :)
imho, for now this can go in as-is with the addition of a drop down in the toolbar to \
switch between modes easily</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> it would be very \
cool to have the ability to switch modes from the toolbar. Yes, that's something \
I want to add. I thought about to Toggle Buttons in the toolbar "Plasma", \
"KWin" which are mutual exclusive. I just didn't want to work on it any \
more today and wanted to push out the review request :-)
Will implement that after Christmas break :-)
The other idea sounds complicated. Not sure whether that would be possible at all \
without exposing complete KWin internals to D-Bus.</pre> <br />
<p>- Martin</p>
<br />
<p>On December 23rd, 2011, 2:24 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2011, 2:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* KWin scripting becomes partly controllable through \
D-Bus
* Desktop Scripting Console can control KWin scripts. For that two new methods to \
PlasmaApp's D-Bus interface are added. If in KWin mode the script is passed to \
KWin through D-Bus
* Plasma Desktop Runner gains new keyword "wm console" to start Desktop \
Scripting Console in KWin mode.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/scripting/scripting.h <span style="color: grey">(b0d00f9)</span></li>
<li>kwin/scripting/scripting.cpp <span style="color: grey">(0a71849)</span></li>
<li>plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.h <span \
style="color: grey">(227748d)</span></li>
<li>plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.cpp <span \
style="color: grey">(617bc69)</span></li>
<li>plasma/desktop/shell/dbus/org.kde.plasma.App.xml <span style="color: \
grey">(e9b6482)</span></li>
<li>plasma/desktop/shell/interactiveconsole.h <span style="color: \
grey">(f94b997)</span></li>
<li>plasma/desktop/shell/interactiveconsole.cpp <span style="color: \
grey">(6f2ff75)</span></li>
<li>plasma/desktop/shell/plasmaapp.h <span style="color: grey">(3c7289c)</span></li>
<li>plasma/desktop/shell/plasmaapp.cpp <span style="color: \
grey">(b630225)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103518/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103518/s/379/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/23/wm-console_400x100.png" \
style="border: 1px black solid;" alt="Desktop Scripting console with KWin \
integration" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic