[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add an "Ignore minimized windows" option to TabBox
From: "Stefano Avallone" <stavallo () unina ! it>
Date: 2011-12-20 19:03:44
Message-ID: 20111220190344.29363.56521 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 20, 2011, 5:33 p.m., Martin Gräßlin wrote:
> > Looks good. Do you have commit access? If not you could provide me the patch with \
> > git format-patch, then I can push and your author information is kept.
> > Of course the ship it is delayed till master is open again. So no, it's too late \
> > for 4.8.
I do not have commit access, so I have sent the patch to you and the kwin ML through \
git-send-email. I wanted to add a "Reviewed-by" (you) line, but I am not very \
familiar with git. Let me know if it is ok or I have to re-sent the patch in a better \
format.
BTW I will look for other simple junior jobs that I can afford...
- Stefano
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103465/#review9123
-----------------------------------------------------------
On Dec. 20, 2011, 9:10 a.m., Stefano Avallone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103465/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2011, 9:10 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> It often happens to me to have many windows open, but, while doing a particular \
> task, I have to frequently switch among a few of them. However, it is quite \
> annoying (at least for me) to frequently use Alt+Tab when many windows are shown. \
> One possible solution is to minimize the windows that are currently not used and \
> only switch among the used ones. This patch adds an "Ignore minimized windows" \
> option to TabBox so that only non-minimized windows are shown when Alt-Tabbing. \
> Clearly, using the alternative setting, it is still possible to switch among all \
> the windows open.
> Just one remark: the boolean condition in kwin/tabbox/clientmodel.cpp:
>
> if (add != NULL && !(add->isMinimized() && tabBox->config().isIgnoreMinimized()))
>
> may cause a segfault if the compiler does not support the short circuit evaluation. \
> Can we safely assume that the compiler supports that or is it better that I add a \
> chain of if statements?
>
> This addresses bug 288342.
> http://bugs.kde.org/show_bug.cgi?id=288342
>
>
> Diffs
> -----
>
> kwin/kcmkwin/kwintabbox/main.cpp 53b3144
> kwin/kcmkwin/kwintabbox/main.ui e81168c
> kwin/tabbox/tabbox.cpp 9cc7935
> kwin/tabbox/tabboxconfig.h c8e5617
> kwin/tabbox/tabboxconfig.cpp c1fa4bb
>
> Diff: http://git.reviewboard.kde.org/r/103465/diff/diff
>
>
> Testing
> -------
>
> The patch is on top of git master as of commit 1dfceed5 ("use correct luminance \
> calculation for greyscale"). I have re-built kde-workspace with the patch applied \
> and the new option works as expected.
>
> Thanks,
>
> Stefano Avallone
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103465/">http://git.reviewboard.kde.org/r/103465/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 20th, 2011, 5:33 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks good. Do you have commit access? If not you could provide me the \
patch with git format-patch, then I can push and your author information is kept.
Of course the ship it is delayed till master is open again. So no, it's too late \
for 4.8.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not have commit \
access, so I have sent the patch to you and the kwin ML through git-send-email. I \
wanted to add a "Reviewed-by" (you) line, but I am not very familiar with \
git. Let me know if it is ok or I have to re-sent the patch in a better format.
BTW I will look for other simple junior jobs that I can afford...</pre>
<br />
<p>- Stefano</p>
<br />
<p>On December 20th, 2011, 9:10 a.m., Stefano Avallone wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Stefano Avallone.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2011, 9:10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It often happens to me to have many windows open, but, while doing a \
particular task, I have to frequently switch among a few of them. However, it is \
quite annoying (at least for me) to frequently use Alt+Tab when many windows are \
shown. One possible solution is to minimize the windows that are currently not used \
and only switch among the used ones. This patch adds an "Ignore minimized \
windows" option to TabBox so that only non-minimized windows are shown when \
Alt-Tabbing. Clearly, using the alternative setting, it is still possible to switch \
among all the windows open.
Just one remark: the boolean condition in kwin/tabbox/clientmodel.cpp:
if (add != NULL && !(add->isMinimized() && \
tabBox->config().isIgnoreMinimized()))
may cause a segfault if the compiler does not support the short circuit evaluation. \
Can we safely assume that the compiler supports that or is it better that I add a \
chain of if statements?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch is on top of git master as of commit 1dfceed5 ("use \
correct luminance calculation for greyscale"). I have re-built kde-workspace \
with the patch applied and the new option works as expected.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288342">288342</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwintabbox/main.cpp <span style="color: grey">(53b3144)</span></li>
<li>kwin/kcmkwin/kwintabbox/main.ui <span style="color: grey">(e81168c)</span></li>
<li>kwin/tabbox/tabbox.cpp <span style="color: grey">(9cc7935)</span></li>
<li>kwin/tabbox/tabboxconfig.h <span style="color: grey">(c8e5617)</span></li>
<li>kwin/tabbox/tabboxconfig.cpp <span style="color: grey">(c1fa4bb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103465/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic