[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: add signals to allow animated maximization &
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-12-09 20:13:10
Message-ID: 20111209201310.6720.47493 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 16, 2011, 8:40 p.m., Thomas Lübking wrote:
> > FTR: i will not need the maximization stuff, found a way on the current API =)
>
> Martin Gräßlin wrote:
> so this request can be discarded? Or is the patch still needed?
The bugwish cannot be fixed w/o the desktopchanged signal.
The maximized part will however best see an update to generalize it to all resizes \
(telling the effects before allows them to dump the state pre and blend to the state \
post - i assume this will be required for any attempt of a hybrid resize. Otherwise \
the judder is quite nasty, whether you've a constant 250ms or a random flicher one \
:-(
If you want to push it for the RC, i'll hurry to cook up an update.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103135/#review8241
-----------------------------------------------------------
On Nov. 15, 2011, 12:27 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103135/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2011, 12:27 a.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> I didn't remove anything but suggest to deprecate the other signals and remove them \
> with 4.9 ("about-to-maximize" was emitted anyway)
> I had planned the maximization thing before, but forget about it in the meantime, \
> sorry.
>
> This addresses bug 213847.
> http://bugs.kde.org/show_bug.cgi?id=213847
>
>
> Diffs
> -----
>
> kwin/effects.h 6530871
> kwin/effects.cpp 000e35c
> kwin/libkwineffects/kwinanimationeffect.h ae11d06
> kwin/libkwineffects/kwineffects.h 780cc89
> kwin/workspace.h 4d7fda5
> kwin/workspace.cpp 6a8e2df
>
> Diff: http://git.reviewboard.kde.org/r/103135/diff/diff
>
>
> Testing
> -------
>
> Yes, if animated maximization (i'm gonna release 4.8beta only sources of the \
> generic animation effect) isn't gonnam make ppl. try the beta, I DON'T KNOW =) \
> (Though i need to implement texture blending on top of it - currently the content \
> change /can/ look suboptimal)
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103135/">http://git.reviewboard.kde.org/r/103135/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 16th, 2011, 8:40 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">FTR: i will not need the maximization stuff, found a way on the current \
API =)</pre> </blockquote>
<p>On December 9th, 2011, 7:54 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">so this request can be \
discarded? Or is the patch still needed?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The bugwish cannot be \
fixed w/o the desktopchanged signal. The maximized part will however best see an \
update to generalize it to all resizes (telling the effects before allows them to \
dump the state pre and blend to the state post - i assume this will be required for \
any attempt of a hybrid resize. Otherwise the judder is quite nasty, whether \
you've a constant 250ms or a random flicher one :-(
If you want to push it for the RC, i'll hurry to cook up an update.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On November 15th, 2011, 12:27 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2011, 12:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I didn't remove anything but suggest to deprecate the other signals \
and remove them with 4.9 ("about-to-maximize" was emitted anyway)
I had planned the maximization thing before, but forget about it in the meantime, \
sorry.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, if animated maximization (i'm gonna release 4.8beta only \
sources of the generic animation effect) isn't gonnam make ppl. try the beta, I \
DON'T KNOW =) (Though i need to implement texture blending on top of it - \
currently the content change /can/ look suboptimal)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=213847">213847</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: grey">(6530871)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(000e35c)</span></li>
<li>kwin/libkwineffects/kwinanimationeffect.h <span style="color: \
grey">(ae11d06)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(780cc89)</span></li>
<li>kwin/workspace.h <span style="color: grey">(4d7fda5)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(6a8e2df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103135/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic