'Re: Review Request: bugfix nouveau GLES + loose texture bindings in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: bugfix nouveau GLES + loose texture bindings in
From:       "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date:       2011-12-01 11:27:56
Message-ID: 20111201112756.17471.94865 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103303/
-----------------------------------------------------------

(Updated Dec. 1, 2011, 11:27 a.m.)

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

Changes
-------

Incorporating Fredrik's suggestion of also requiring strict binding in the =
mesa 7.10 case.

Description
-------

There seems to be a problem with nouveau GLES if you want to create an
EGLImageKHR more than once for the same pixmap in a frame. This patch
circumvents the problem in the way that it implements tfp the same way
as the mesa example in mesa/demos/src/egl/opengles1/texture_from_pixmap.c d=
oes it.
A nice side effect of this is that it also avoids the overhead of recreating
the texture for every damaged window.

Diffs (updated)
-----

  kwin/libkwineffects/kwinglplatform.cpp f09dc18 =

  kwin/scene_opengl.h e13d8a5 =

  kwin/scene_opengl.cpp 47015b3 =

  kwin/scene_opengl_egl.cpp 22e082c =

Diff: http://git.reviewboard.kde.org/r/103303/diff/diff

Testing
-------

nouveau works

Thanks,

Philipp Knechtges

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103303/">http://git.reviewboard.kde.org/r/103303/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated Dec. 1, 2011, 11:27 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Incorporating Fredrik&#39;s suggestion of also requiring strict binding \
in the mesa 7.10 case.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There seems to be a problem with nouveau GLES if you want to create an \
EGLImageKHR more than once for the same pixmap in a frame. This patch circumvents the \
problem in the way that it implements tfp the same way as the mesa example in \
mesa/demos/src/egl/opengles1/texture_from_pixmap.c does it. A nice side effect of \
this is that it also avoids the overhead of recreating the texture for every damaged \
window.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">nouveau works</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwinglplatform.cpp <span style="color: \
grey">(f09dc18)</span></li>

 <li>kwin/scene_opengl.h <span style="color: grey">(e13d8a5)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: grey">(47015b3)</span></li>

 <li>kwin/scene_opengl_egl.cpp <span style="color: grey">(22e082c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103303/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 