'Re: Review Request: Implementing _KDE_NET_WM_OPAQUE_REGION'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Implementing _KDE_NET_WM_OPAQUE_REGION
From:       "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date:       2011-10-22 22:11:18
Message-ID: 20111022221118.10082.21494 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102933/
-----------------------------------------------------------

(Updated Oct. 22, 2011, 10:11 p.m.)

Review request for kwin, Thomas L=C3=BCbking, Martin Gr=C3=A4=C3=9Flin, Fre=
drik H=C3=B6glund, and Hugo Pereira Da Costa.

Changes
-------

- add missing initialization for unmanaged windows
- add the missing Toplevel::copyToDeleted assignment

Description
-------

kwin: implement _KDE_NET_WM_OPAQUE_REGION

This patch implements an XProperty named _KDE_NET_WM_OPAQUE_REGION
which gives the compositor the information which part of a window
is opaque although it is an ARGB visual. The basic ideas are from
http://www.mail-archive.com/wm-spec-list@gnome.org/msg00715.html

Additionally the patch makes kwin  use this information to do a better
clipping in Scene::paintSimpleScreen which should result in a higher
performance.

Diffs (updated)
-----

  kwin/atoms.h e51411f =

  kwin/atoms.cpp f53ef31 =

  kwin/events.cpp 94ddfaa =

  kwin/manage.cpp 1f41072 =

  kwin/scene.cpp 3406259 =

  kwin/toplevel.h 2f71d23 =

  kwin/toplevel.cpp 8ec1b82 =

  kwin/unmanaged.cpp 3fae012 =

Diff: http://git.reviewboard.kde.org/r/102933/diff/diff

Testing
-------

I have a working quick and dirty oxygen-transparent implementation:
https://gist.github.com/1305813

Thanks,

Philipp Knechtges

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102933/">http://git.reviewboard.kde.org/r/102933/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Thomas Lübking, Martin Gräßlin, Fredrik Höglund, \
and Hugo Pereira Da Costa.</div> <div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated Oct. 22, 2011, 10:11 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- add missing initialization for unmanaged windows
- add the missing Toplevel::copyToDeleted assignment</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kwin: implement _KDE_NET_WM_OPAQUE_REGION

This patch implements an XProperty named _KDE_NET_WM_OPAQUE_REGION
which gives the compositor the information which part of a window
is opaque although it is an ARGB visual. The basic ideas are from
http://www.mail-archive.com/wm-spec-list@gnome.org/msg00715.html

Additionally the patch makes kwin  use this information to do a better
clipping in Scene::paintSimpleScreen which should result in a higher
performance.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have a working quick and dirty oxygen-transparent implementation: \
https://gist.github.com/1305813</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/atoms.h <span style="color: grey">(e51411f)</span></li>

 <li>kwin/atoms.cpp <span style="color: grey">(f53ef31)</span></li>

 <li>kwin/events.cpp <span style="color: grey">(94ddfaa)</span></li>

 <li>kwin/manage.cpp <span style="color: grey">(1f41072)</span></li>

 <li>kwin/scene.cpp <span style="color: grey">(3406259)</span></li>

 <li>kwin/toplevel.h <span style="color: grey">(2f71d23)</span></li>

 <li>kwin/toplevel.cpp <span style="color: grey">(8ec1b82)</span></li>

 <li>kwin/unmanaged.cpp <span style="color: grey">(3fae012)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102933/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 