[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Do not restart the compositor when screen changes
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2011-10-20 23:15:09
Message-ID: 20111020231509.5826.73061 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 20, 2011, 10:59 p.m., Alex Fiestas wrote:
> > Quick test before going to sleep, removing the external screen resulted=
in the weird thing posted as an attachmed.
> > =
> > Restoring the external screen was fast and perfect, lovely !
http://wstaw.org/m/2011/10/21/feeder3.png
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102927/#review7517
-----------------------------------------------------------
On Oct. 20, 2011, 8:26 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102927/
> -----------------------------------------------------------
> =
> (Updated Oct. 20, 2011, 8:26 p.m.)
> =
> =
> Review request for kwin and Alex Fiestas.
> =
> =
> Description
> -------
> =
> This is an attempt to react on screen changes without restarting the comp=
ositor. Effects are notified through a signal and can react to it. For thos=
e effects which may be no longer supported with the new screen size I added=
a method to allow them to reload themselves (currently used by blur effect=
which needs a render target).
> =
> Changing screen flickers a few times here but compositing is never turned=
off, so already a more pleasant experience.
> =
> There are probably many effects which need to be updated. I try to screen=
for them and adjust them this weekend.
> =
> =
> Diffs
> -----
> =
> kwin/effects.h fc0c34d =
> kwin/effects.cpp 4f8116a =
> kwin/effects/blur/blur.h 313f311 =
> kwin/effects/blur/blur.cpp c566e34 =
> kwin/geometry.cpp 71335ae =
> kwin/libkwineffects/kwineffects.h 6ae0a6d =
> kwin/libkwineffects/kwinglutils.h 876cf3a =
> kwin/libkwineffects/kwinglutils.cpp 7e51bc9 =
> kwin/overlaywindow.h 14d2d58 =
> kwin/overlaywindow.cpp 43f1a52 =
> kwin/scene.h b9ba85a =
> kwin/scene.cpp 3406259 =
> kwin/scene_opengl.h e13d8a5 =
> kwin/scene_opengl.cpp 47015b3 =
> kwin/scene_opengl_glx.cpp aa98a63 =
> =
> Diff: http://git.reviewboard.kde.org/r/102927/diff/diff
> =
> =
> Testing
> -------
> =
> Tested with:
> * OpenGL 1
> * OpenGL ES 2
> =
> Untested
> * XRender
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102927/">http://git.reviewboard.kde.org/r/102927/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 20th, 2011, 10:59 p.m., <b>Alex \
Fiestas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Quick test before going to sleep, removing the external screen resulted \
in the weird thing posted as an attachmed.
Restoring the external screen was fast and perfect, lovely !</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">http://wstaw.org/m/2011/10/21/feeder3.png</pre> <br />
<p>- Alex</p>
<br />
<p>On October 20th, 2011, 8:26 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Alex Fiestas.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2011, 8:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is an attempt to react on screen changes without restarting the \
compositor. Effects are notified through a signal and can react to it. For those \
effects which may be no longer supported with the new screen size I added a method to \
allow them to reload themselves (currently used by blur effect which needs a render \
target).
Changing screen flickers a few times here but compositing is never turned off, so \
already a more pleasant experience.
There are probably many effects which need to be updated. I try to screen for them \
and adjust them this weekend.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with:
* OpenGL 1
* OpenGL ES 2
Untested
* XRender</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: grey">(fc0c34d)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(4f8116a)</span></li>
<li>kwin/effects/blur/blur.h <span style="color: grey">(313f311)</span></li>
<li>kwin/effects/blur/blur.cpp <span style="color: grey">(c566e34)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(71335ae)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(6ae0a6d)</span></li>
<li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(876cf3a)</span></li>
<li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(7e51bc9)</span></li>
<li>kwin/overlaywindow.h <span style="color: grey">(14d2d58)</span></li>
<li>kwin/overlaywindow.cpp <span style="color: grey">(43f1a52)</span></li>
<li>kwin/scene.h <span style="color: grey">(b9ba85a)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(3406259)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(e13d8a5)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(47015b3)</span></li>
<li>kwin/scene_opengl_glx.cpp <span style="color: grey">(aa98a63)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102927/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic