'Review Request: Window rules cleanup #1'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Window rules cleanup #1
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2011-09-26 16:41:44
Message-ID: 20110926164144.12498.95278 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102711/
-----------------------------------------------------------

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

Description
-------

Driven by the documentation discussion. This part should be ok for backport=
ing.

- remove all "extra role" references. The attribute was only "TODO" and i c=
ould not find a single reference to such property or whatever its supposed =
to be
- =

- connect the shortcut edit button (there's actually a present input dialog=
 since this goes beyond the kgblobalaccel capabilities)
- hide all regex edit buttons. So far there's no GUI editor, the kregexpedi=
t thing seems unmaintained and would require a 3rd too presence check anyway

I'll do another RR for non 4.7 suiting changes.

Diffs
-----

  kwin/kcmkwin/kwinrules/detectwidget.cpp dd3b6a3 =

  kwin/kcmkwin/kwinrules/detectwidget.ui 8647a86 =

  kwin/kcmkwin/kwinrules/main.cpp 4f41b51 =

  kwin/kcmkwin/kwinrules/ruleswidget.h cb7b1f9 =

  kwin/kcmkwin/kwinrules/ruleswidget.cpp 3c5ad4d =

  kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 95a4c94 =

  kwin/rules.h 9cda1ca =

  kwin/rules.cpp d188202 =

Diff: http://git.reviewboard.kde.org/r/102711/diff/diff

Testing
-------

Thanks,

Thomas L=C3=BCbking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102711/">http://git.reviewboard.kde.org/r/102711/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Driven by the documentation discussion. This part should be ok for \
backporting.

- remove all &quot;extra role&quot; references. The attribute was only \
&quot;TODO&quot; and i could not find a single reference to such property or whatever \
                its supposed to be
- 
- connect the shortcut edit button (there&#39;s actually a present input dialog since \
                this goes beyond the kgblobalaccel capabilities)
- hide all regex edit buttons. So far there&#39;s no GUI editor, the kregexpedit \
thing seems unmaintained and would require a 3rd too presence check anyway

I&#39;ll do another RR for non 4.7 suiting changes.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwinrules/detectwidget.cpp <span style="color: \
grey">(dd3b6a3)</span></li>

 <li>kwin/kcmkwin/kwinrules/detectwidget.ui <span style="color: \
grey">(8647a86)</span></li>

 <li>kwin/kcmkwin/kwinrules/main.cpp <span style="color: grey">(4f41b51)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidget.h <span style="color: \
grey">(cb7b1f9)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidget.cpp <span style="color: \
grey">(3c5ad4d)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidgetbase.ui <span style="color: \
grey">(95a4c94)</span></li>

 <li>kwin/rules.h <span style="color: grey">(9cda1ca)</span></li>

 <li>kwin/rules.cpp <span style="color: grey">(d188202)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102711/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 