[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: add EffectWindow::windowType()
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-09-25 13:32:08
Message-ID: 20110925133208.12261.81968 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 18, 2011, 6:19 a.m., Martin Gräßlin wrote:
> > But only master. Distros (especially Debian and Kubuntu) are going to kill us if \
> > we do an ABI break in a minor release.
http://commits.kde.org/kde-workspace/04e08c5590aca6d4d7e68b0949469c3f28d56a58
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102653/#review6611
-----------------------------------------------------------
On Sept. 18, 2011, 12:03 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102653/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2011, 12:03 a.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> I could quite use that for the generic animation effect (so i can easily match a \
> config value against the actual window type instead of needing an if; then; else; \
> orgy on not that cheap type checks that all to windowType() == XYZ)
> I'd like to have it in 4.7 so i can release the generic animation effect standalone \
> asap - get some feedback and testing before -iff- including it to 4.8
>
> Diffs
> -----
>
> kwin/effects.h abff777
> kwin/effects.cpp e0c76cb
> kwin/libkwineffects/kwineffects.h 87a676d
>
> Diff: http://git.reviewboard.kde.org/r/102653/diff/diff
>
>
> Testing
> -------
>
> It compiles, yeah!
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102653/">http://git.reviewboard.kde.org/r/102653/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 18th, 2011, 6:19 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">But only master. Distros (especially Debian and Kubuntu) are going to \
kill us if we do an ABI break in a minor release.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">http://commits.kde.org/kde-workspace/04e08c5590aca6d4d7e68b0949469c3f28d56a58</pre>
<br />
<p>- Thomas</p>
<br />
<p>On September 18th, 2011, 12:03 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2011, 12:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I could quite use that for the generic animation effect (so i can easily \
match a config value against the actual window type instead of needing an if; then; \
else; orgy on not that cheap type checks that all to windowType() == XYZ)
I'd like to have it in 4.7 so i can release the generic animation effect \
standalone asap - get some feedback and testing before -iff- including it to \
4.8</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles, yeah!</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: grey">(abff777)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(e0c76cb)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(87a676d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102653/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic