[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: rework some present windows glitches
From: "Commit Hook" <null () kde ! org>
Date: 2011-09-23 15:53:24
Message-ID: 20110923155324.9052.89219 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101318/#review6767
-----------------------------------------------------------
This review has been submitted with commit dbe57396853f9995a9b3d7ab5d55f88fc730512a \
by Marco Martin to branch active-development/screenlocker.
- Commit
On Aug. 5, 2011, 11:36 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101318/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2011, 11:36 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> fix close button side for present windows effect
> BUG: 262543
>
> ** this does currently require to link kdecorations. ultimately i'd prefer to hand \
> out options on a string/qhash based qvariant return (and actually have some code, \
> but not in this branch ;-)
> pint desktop as background when including desktop in switcher
> BUG: 262137
>
> ** since the selected window is elevated (because of below) this will also "hide" \
> all other windows when the desktop is selected
> zoom windows as hover/selection indicaton (1/8 of the screen or 105%)
> BUG: 215348
> CCBUG: 175521
>
> ** i'm not happy with the outcome of scaling tiny windows - it conflicts with the \
> closebutton (which cannot be moved outside since this would prevent access to \
> adjacent windows. This is a structural problem and either considered ok or we \
> cannot zoom or we don't show a closer when the window scales "too much")
> ----
>
> Other changes:
> - no closeview on the "show desktop" desktop
> - closeview appears immediately but is disabled for a short time. This allows the \
> user to notice the closer immediately but prevents him from accidental clicks \
> before his brain handled the input and stopped the digit ;-) - currently the \
> closeview is shown armed with a slight delay, what is actually even pretty mean
>
> This addresses bugs 175521, 215348, 262137, and 262543.
> http://bugs.kde.org/show_bug.cgi?id=175521
> http://bugs.kde.org/show_bug.cgi?id=215348
> http://bugs.kde.org/show_bug.cgi?id=262137
> http://bugs.kde.org/show_bug.cgi?id=262543
>
>
> Diffs
> -----
>
> kwin/effects.h 75df0cc
> kwin/effects.cpp 0c7701d
> kwin/effects/presentwindows/presentwindows.h 58c5266
> kwin/effects/presentwindows/presentwindows.cpp 0dd0744
> kwin/libkdecorations/kdecorationfactory.h 978d4b2
> kwin/libkdecorations/kdecorationfactory.cpp 05b33cf
> kwin/libkwineffects/kwineffects.h a93d398
> kwin/libkwineffects/kwinglobals.h f34bdba
> kwin/workspace.h 492d1ca
>
> Diff: http://git.reviewboard.kde.org/r/101318/diff
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101318/">http://git.reviewboard.kde.org/r/101318/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit dbe57396853f9995a9b3d7ab5d55f88fc730512a by Marco Martin to \
branch active-development/screenlocker.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 5th, 2011, 11:36 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2011, 11:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fix close button side for present windows effect
BUG: 262543
** this does currently require to link kdecorations. ultimately i'd prefer to \
hand out options on a string/qhash based qvariant return (and actually have some \
code, but not in this branch ;-)
pint desktop as background when including desktop in switcher
BUG: 262137
** since the selected window is elevated (because of below) this will also \
"hide" all other windows when the desktop is selected
zoom windows as hover/selection indicaton (1/8 of the screen or 105%)
BUG: 215348
CCBUG: 175521
** i'm not happy with the outcome of scaling tiny windows - it conflicts with the \
closebutton (which cannot be moved outside since this would prevent access to \
adjacent windows. This is a structural problem and either considered ok or we cannot \
zoom or we don't show a closer when the window scales "too much")
----
Other changes:
- no closeview on the "show desktop" desktop
- closeview appears immediately but is disabled for a short time. This allows the \
user to notice the closer immediately but prevents him from accidental clicks before \
his brain handled the input and stopped the digit ;-) - currently the closeview is \
shown armed with a slight delay, what is actually even pretty mean</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=175521">175521</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=215348">215348</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=262137">262137</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=262543">262543</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: grey">(75df0cc)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(0c7701d)</span></li>
<li>kwin/effects/presentwindows/presentwindows.h <span style="color: \
grey">(58c5266)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(0dd0744)</span></li>
<li>kwin/libkdecorations/kdecorationfactory.h <span style="color: \
grey">(978d4b2)</span></li>
<li>kwin/libkdecorations/kdecorationfactory.cpp <span style="color: \
grey">(05b33cf)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(a93d398)</span></li>
<li>kwin/libkwineffects/kwinglobals.h <span style="color: \
grey">(f34bdba)</span></li>
<li>kwin/workspace.h <span style="color: grey">(492d1ca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101318/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic