'Re: Review Request: Optimizing Blur Part III'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Optimizing Blur Part III
From:       "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date:       2011-09-22 13:08:25
Message-ID: 20110922130825.26247.13771 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102665/
-----------------------------------------------------------

(Updated Sept. 22, 2011, 1:08 p.m.)

Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Fredrik H=C3=B6glund.

Changes
-------

adding an addRepaintFull call to the PresentWindows effect

Summary
-------

This patch introduces some kind of damage propagation. In the old version o=
f the blur effect
we had to repaint the whole window if sth behind the blurred area was damag=
ed. The new texture
cache, which was introduced by the last patch, gives us the opportunity to =
only update parts of
blurred background texture. This means that the damaged area can only propa=
gate with the speed
of the blurring radius per window layer.

Diffs (updated)
-----

  kwin/effects/blur/blur.h d96f9f6 =

  kwin/effects/blur/blur.cpp 3c4a4b8 =

  kwin/effects/presentwindows/presentwindows.cpp 5e7589c =

Diff: http://git.reviewboard.kde.org/r/102665/diff

Testing (updated)
-------

PresentWindows works now
so far i didnt notice any other graphical glitches

Thanks,

Philipp

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102665/">http://git.reviewboard.kde.org/r/102665/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Fredrik Höglund.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated Sept. 22, 2011, 1:08 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">adding an addRepaintFull call to the PresentWindows effect</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch introduces some kind of damage propagation. In the old \
version of the blur effect we had to repaint the whole window if sth behind the \
blurred area was damaged. The new texture cache, which was introduced by the last \
patch, gives us the opportunity to only update parts of blurred background texture. \
This means that the damaged area can only propagate with the speed of the blurring \
radius per window layer.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">PresentWindows works now so far i didnt notice any other graphical \
glitches</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/blur/blur.h <span style="color: grey">(d96f9f6)</span></li>

 <li>kwin/effects/blur/blur.cpp <span style="color: grey">(3c4a4b8)</span></li>

 <li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(5e7589c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102665/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 