[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Optimizing Blur Part II
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-09-15 20:37:00
Message-ID: 20110915203700.30327.61729 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101977/#review6543
-----------------------------------------------------------
I cannot say anything about it: kwin_gles + blur is completely broken with =
and without the patch (had not used it for quite some time).
- Martin
On Sept. 4, 2011, 3:58 p.m., Philipp Knechtges wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101977/
> -----------------------------------------------------------
> =
> (Updated Sept. 4, 2011, 3:58 p.m.)
> =
> =
> Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Fredrik H=C3=B6glun=
d.
> =
> =
> Summary
> -------
> =
> This patch adds an optional texture cache to the blur effect. The texture=
cache allows one to partially repaint the blurred region
> if the region or a window on top it is damaged. This patch does not chang=
e anything on the behavior of the blur effect if caching is turned off.
> =
> Some facts about the texture cache:
> - It does not a full cache of the window's background. To achieve this on=
e would have to shrink the clip of all following windows which results in l=
ess performance.
> - We only cache the horizontally blurred texture. I didnt test whether it=
is better to cache the full result.
> - For every window we have to keep a texture of the size of the blurred a=
rea in the GFX memory.
> =
> Although we so far only cache all windows or none the prePaintWindow func=
tion is designed to add the possibility to decide on a per-window basis whi=
ch window
> should be cached. But IMO this is not worth the effort cause the extra me=
musage isnt that high.
> =
> =
> =
> Diffs
> -----
> =
> kwin/effects/_test/demo_liquid.cpp 5b1ef03 =
> kwin/effects/_test/test_fbo.cpp 4cb646f =
> kwin/effects/blur/blur.h 3c0922b =
> kwin/effects/blur/blur.cpp c8b39b6 =
> kwin/effects/blur/blur_config.cpp 0612599 =
> kwin/effects/blur/blur_config.ui 3b99afd =
> kwin/effects/blur/blurshader.h 4308be9 =
> kwin/effects/blur/blurshader.cpp decd430 =
> kwin/effects/logout/logout.cpp 7880dae =
> kwin/effects/lookingglass/lookingglass.cpp 783823e =
> kwin/effects/magnifier/magnifier.cpp 3e216f6 =
> kwin/effects/screenshot/screenshot.cpp d12d77d =
> kwin/lanczosfilter.cpp 7c0bad9 =
> kwin/libkwineffects/kwinglutils.h 59bac2e =
> kwin/libkwineffects/kwinglutils.cpp e1d5b7b =
> =
> Diff: http://git.reviewboard.kde.org/r/101977/diff
> =
> =
> Testing
> -------
> =
> GL: works
> GLES: compiles
> KCM: works
> =
> =
> Thanks,
> =
> Philipp
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101977/">http://git.reviewboard.kde.org/r/101977/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I cannot say anything \
about it: kwin_gles + blur is completely broken with and without the patch (had not \
used it for quite some time).</pre> <br />
<p>- Martin</p>
<br />
<p>On September 4th, 2011, 3:58 p.m., Philipp Knechtges wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Fredrik Höglund.</div>
<div>By Philipp Knechtges.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2011, 3:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds an optional texture cache to the blur effect. The \
texture cache allows one to partially repaint the blurred region if the region or a \
window on top it is damaged. This patch does not change anything on the behavior of \
the blur effect if caching is turned off.
Some facts about the texture cache:
- It does not a full cache of the window's background. To achieve this one would \
have to shrink the clip of all following windows which results in \
less performance.
- We only cache the horizontally blurred texture. I didnt test whether it is better \
to cache the full result.
- For every window we have to keep a texture of the size of the blurred area in the \
GFX memory.
Although we so far only cache all windows or none the prePaintWindow function is \
designed to add the possibility to decide on a per-window basis which window should \
be cached. But IMO this is not worth the effort cause the extra memusage isnt that \
high. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">GL: works
GLES: compiles
KCM: works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/_test/demo_liquid.cpp <span style="color: \
grey">(5b1ef03)</span></li>
<li>kwin/effects/_test/test_fbo.cpp <span style="color: grey">(4cb646f)</span></li>
<li>kwin/effects/blur/blur.h <span style="color: grey">(3c0922b)</span></li>
<li>kwin/effects/blur/blur.cpp <span style="color: grey">(c8b39b6)</span></li>
<li>kwin/effects/blur/blur_config.cpp <span style="color: \
grey">(0612599)</span></li>
<li>kwin/effects/blur/blur_config.ui <span style="color: grey">(3b99afd)</span></li>
<li>kwin/effects/blur/blurshader.h <span style="color: grey">(4308be9)</span></li>
<li>kwin/effects/blur/blurshader.cpp <span style="color: grey">(decd430)</span></li>
<li>kwin/effects/logout/logout.cpp <span style="color: grey">(7880dae)</span></li>
<li>kwin/effects/lookingglass/lookingglass.cpp <span style="color: \
grey">(783823e)</span></li>
<li>kwin/effects/magnifier/magnifier.cpp <span style="color: \
grey">(3e216f6)</span></li>
<li>kwin/effects/screenshot/screenshot.cpp <span style="color: \
grey">(d12d77d)</span></li>
<li>kwin/lanczosfilter.cpp <span style="color: grey">(7c0bad9)</span></li>
<li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(59bac2e)</span></li>
<li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(e1d5b7b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101977/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic