[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: "smooth"
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-09-11 13:29:32
Message-ID: 20110911132932.28109.88642 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102572/
-----------------------------------------------------------
(Updated Sept. 11, 2011, 1:29 p.m.)
Review request for kwin and Martin Gräßlin.
Changes
-------
- Introduced a mutex and a timer (which controls choppy vs. flicker for slow clients \
and currently "enforces" 10 -scaled- resizes per sencond)
- Set the demanded geometry when finishing moveResize (jumped back to the last \
complete resize before)
Summary
-------
I today stumbled across some blogentry by a person, let's call him "M." where this \
person promoted "smooth" window resizing in kwin 4.8, put my name below it and \
accomplished it with a youtube video showing, well, "synchronous" resizing...
Makes me a fool and him a liar and caused some - is that what they call a shitstorm?
Probably not entirely ;-)
So tonight, I sat down to start writing what I basically wanted to see ever since \
there was compositing (in kwin or compiz) being a hybrid resize: as fast as texture \
scaling but with online content update.
The current patch is FOR GENERAL REVIEW and not what i'd consider "perfect".
The two major defects are that
a) it exposes a problem with the client texture when changing between the texture \
scale and the real resize, ie. flicker is back :-( (it is *not* the former xsync \
issue, though and not comparable either) b) the in-client changes still happen quite \
"snappy" ie. you get the scaled icons in dolphin and they're then suddenly replaced \
by the bigger and differently arranged icons.
For a) i'll have to look after some kind of mutex and for b) in thought about a fast \
crossfade.
I minor "defect" could be considered that this is implemented in the kwin core and \
not as some effect (this could be changed, though) and by this might require an \
option (for slow scaling xrender backends - iff someone wanted to use such)
The big fat pro is that the window geometry now resizes _really_ smooth - even for \
gtk+ clients =)
So, should i keep investigating in that direction?
Diffs (updated)
-----
kwin/client.h 66b9c46
kwin/client.cpp a6f0618
kwin/composite.cpp a8bb42e
kwin/effects.cpp daf4a75
kwin/events.cpp 94ddfaa
kwin/geometry.cpp 5c7cbe5
kwin/scene.cpp 3406259
Diff: http://git.reviewboard.kde.org/r/102572/diff
Testing
-------
Yes, 2500ms timeout for xsync. No issue with gtk+ or clemens testcase.
Thanks,
Thomas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102572/">http://git.reviewboard.kde.org/r/102572/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2011, 1:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Introduced a mutex and a timer (which controls choppy vs. flicker for \
slow clients and currently "enforces" 10 -scaled- resizes \
per sencond)
- Set the demanded geometry when finishing moveResize (jumped back to the last \
complete resize before)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I today stumbled across some blogentry by a person, let's call him \
"M." where this person promoted "smooth" window resizing in kwin \
4.8, put my name below it and accomplished it with a youtube video showing, well, \
"synchronous" resizing...
Makes me a fool and him a liar and caused some - is that what they call a shitstorm?
Probably not entirely ;-)
So tonight, I sat down to start writing what I basically wanted to see ever since \
there was compositing (in kwin or compiz) being a hybrid resize: as fast as texture \
scaling but with online content update.
The current patch is FOR GENERAL REVIEW and not what i'd consider \
"perfect". The two major defects are that
a) it exposes a problem with the client texture when changing between the texture \
scale and the real resize, ie. flicker is back :-( (it is *not* the former xsync \
issue, though and not comparable either) b) the in-client changes still happen quite \
"snappy" ie. you get the scaled icons in dolphin and they're then \
suddenly replaced by the bigger and differently arranged icons.
For a) i'll have to look after some kind of mutex and for b) in thought about a \
fast crossfade.
I minor "defect" could be considered that this is implemented in the kwin \
core and not as some effect (this could be changed, though) and by this might require \
an option (for slow scaling xrender backends - iff someone wanted to use such)
The big fat pro is that the window geometry now resizes _really_ smooth - even for \
gtk+ clients =)
So, should i keep investigating in that direction?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, 2500ms timeout for xsync. No issue with gtk+ or clemens \
testcase.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.h <span style="color: grey">(66b9c46)</span></li>
<li>kwin/client.cpp <span style="color: grey">(a6f0618)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(a8bb42e)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(daf4a75)</span></li>
<li>kwin/events.cpp <span style="color: grey">(94ddfaa)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(5c7cbe5)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(3406259)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102572/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic