[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Clear deleted window thumbnails
From: "Commit Hook" <null () kde ! org>
Date: 2011-09-10 5:58:45
Message-ID: 20110910055845.8378.10903 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102445/#review6365
-----------------------------------------------------------
This review has been submitted with commit aef5a39dc475cd5e1b2c73b2fd190e3b=
8aeb40b0 by Martin Gr=C3=A4=C3=9Flin to branch KDE/4.7.
- Commit
On Aug. 26, 2011, 2:57 p.m., Sebastian K=C3=BCgler wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102445/
> -----------------------------------------------------------
> =
> (Updated Aug. 26, 2011, 2:57 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Summary
> -------
> =
> When thumbnails are shown and a window is deleted, only the other, still =
existing windows are being repainted. The deleted window stays on the scree=
n until repainted. In the typical taskbar thumbnail case, that's not a prob=
lem, since the thumbnail of a deleted window is just never shown (no toolti=
ps in that case).
> =
> In the Windowstrip applet, which is used as application switcher in Activ=
e, when the window strip is not as wide as the screen, the windows shift le=
ft, leave a blank space on the right which doesn't get cleared, so a ghost =
of the window stays on screen.
> =
> The patch addresses this by adding the rect of the vanishing window to th=
e area to repaint in the next frame, essentially clearing exactly the part =
that we want.
> =
> I'd like to commit to master and 4.7.
> =
> =
> Diffs
> -----
> =
> kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp 7761ba5 =
> =
> Diff: http://git.reviewboard.kde.org/r/102445/diff
> =
> =
> Testing
> -------
> =
> start plasma-contour, with 3 open windows, close on of them from the wind=
owstrip.
> =
> Without the patch, you'll see 3 windows painted, the third of which gets =
cleared only after an artificially triggered repaint, e.g. by dragging the =
rest of the windows over it.
> =
> With the patch, behaviour is as expected, the preview of the rightmost wi=
ndow is cleared.
> =
> =
> Thanks,
> =
> Sebastian
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102445/">http://git.reviewboard.kde.org/r/102445/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit aef5a39dc475cd5e1b2c73b2fd190e3b8aeb40b0 by Martin Gräßlin to \
branch KDE/4.7.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 26th, 2011, 2:57 p.m., Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2011, 2:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When thumbnails are shown and a window is deleted, only the other, still \
existing windows are being repainted. The deleted window stays on the screen until \
repainted. In the typical taskbar thumbnail case, that's not a problem, since the \
thumbnail of a deleted window is just never shown (no tooltips in that case).
In the Windowstrip applet, which is used as application switcher in Active, when the \
window strip is not as wide as the screen, the windows shift left, leave a blank \
space on the right which doesn't get cleared, so a ghost of the window stays on \
screen.
The patch addresses this by adding the rect of the vanishing window to the area to \
repaint in the next frame, essentially clearing exactly the part that we want.
I'd like to commit to master and 4.7.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">start plasma-contour, with 3 open windows, close on of them from the \
windowstrip.
Without the patch, you'll see 3 windows painted, the third of which gets cleared \
only after an artificially triggered repaint, e.g. by dragging the rest of the \
windows over it.
With the patch, behaviour is as expected, the preview of the rightmost window is \
cleared.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp <span style="color: \
grey">(7761ba5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102445/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic