'Re: Review Request: Introduce class DecorationPaintRedirector for'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Introduce class DecorationPaintRedirector for
From:       "Arthur Arlt" <arre2000 () gmx ! de>
Date:       2011-09-09 17:20:46
Message-ID: 20110909172046.9051.2037 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102422/
-----------------------------------------------------------

(Updated Sept. 9, 2011, 5:20 p.m.)

Review request for kwin.

Changes
-------

rebased to current master ;)

Summary
-------

This patch introduces the new class DecorationPaintRedirector. It inherits =
from PaintRedirector and covers the functionality for decoration handling w=
hen compositing is active. This functionality was moved from Client to this=
 new class.
The reason for doing this is to get rid of the Client dependency in class S=
cene.
This is an initial review request. There are still some Client dependencies=
 left. But it works so far except for changing the decoration in composited=
 mode or removing no border. Doing this does not lead to a crash but the de=
corations are not updated. Newly added clients are displayed correctly with=
 the new decoration. Should be not that hard to fix it; will be done the ne=
xt days ;)

Diffs (updated)
-----

  kwin/CMakeLists.txt bde6626 =

  kwin/client.h 66b9c46 =

  kwin/client.cpp a6f0618 =

  kwin/composite.cpp a8bb42e =

  kwin/decorationpaintredirector.h PRE-CREATION =

  kwin/decorationpaintredirector.cpp PRE-CREATION =

  kwin/deleted.cpp f465159 =

  kwin/paintredirector.h bb5d67c =

  kwin/paintredirector.cpp 7ed4d6f =

  kwin/scene.h b9ba85a =

  kwin/scene.cpp 3406259 =

  kwin/scene_opengl.cpp 47015b3 =

  kwin/scene_xrender.cpp fc08289 =

Diff: http://git.reviewboard.kde.org/r/102422/diff

Testing
-------

Works for both OpenGL and XRender on my system. However, as told in the des=
cription, changing the decoration (in composited mode)does not lead to a cr=
ash, but does not update the decorations for existing clients. Feel free to=
 tell me the solution if it is obvious to you.

Thanks,

Arthur

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102422/">http://git.reviewboard.kde.org/r/102422/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Arthur Arlt.</div>

<p style="color: grey;"><i>Updated Sept. 9, 2011, 5:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">rebased to current master ;)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch introduces the new class DecorationPaintRedirector. It \
inherits from PaintRedirector and covers the functionality for decoration handling \
when compositing is active. This functionality was moved from Client to this new \
class. The reason for doing this is to get rid of the Client dependency in class \
Scene. This is an initial review request. There are still some Client dependencies \
left. But it works so far except for changing the decoration in composited mode or \
removing no border. Doing this does not lead to a crash but the decorations are not \
updated. Newly added clients are displayed correctly with the new decoration. Should \
be not that hard to fix it; will be done the next days ;)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for both OpenGL and XRender on my system. However, as told in the \
description, changing the decoration (in composited mode)does not lead to a crash, \
but does not update the decorations for existing clients. Feel free to tell me the \
solution if it is obvious to you.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/CMakeLists.txt <span style="color: grey">(bde6626)</span></li>

 <li>kwin/client.h <span style="color: grey">(66b9c46)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(a6f0618)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(a8bb42e)</span></li>

 <li>kwin/decorationpaintredirector.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/decorationpaintredirector.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/deleted.cpp <span style="color: grey">(f465159)</span></li>

 <li>kwin/paintredirector.h <span style="color: grey">(bb5d67c)</span></li>

 <li>kwin/paintredirector.cpp <span style="color: grey">(7ed4d6f)</span></li>

 <li>kwin/scene.h <span style="color: grey">(b9ba85a)</span></li>

 <li>kwin/scene.cpp <span style="color: grey">(3406259)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: grey">(47015b3)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: grey">(fc08289)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102422/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 