[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: some fixes for kwin
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-09-09 14:37:10
Message-ID: 20110909143710.31316.28253 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102555/#review6355
-----------------------------------------------------------
Ship it!
a obviously only for 4.7 branch. (I will afterwards have a look at the performance \
difference and might inform packagers about the patch as the bug has been present \
since ever :-()
- Martin
On Sept. 8, 2011, 9:16 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102555/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2011, 9:16 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> a) replace non-const QVector::operator[] with ::at() in effects.cpp
> b) fix yet another tabbing nullpointer access... (client.cpp=
> c) fix geom_pretile/geom_restore with BorderlessMaximized (geometry.cpp)
> d) add missing connects for the kwinrules matches (title, extra,machine) \
> (ruleswidget.cpp)
> are 4 commits, stacked in one RR for convenience ;-)
>
>
> This addresses bugs (279529), 281506 and 281596.
> http://bugs.kde.org/show_bug.cgi?id=(279529)
> http://bugs.kde.org/show_bug.cgi?id=281506
> http://bugs.kde.org/show_bug.cgi?id=281596
>
>
> Diffs
> -----
>
> kwin/effects.cpp e0c76cb
> kwin/geometry.cpp 1bc3a92
> kwin/kcmkwin/kwinrules/ruleswidget.cpp 300191e
> kwin/manage.cpp a802623
>
> Diff: http://git.reviewboard.kde.org/r/102555/diff
>
>
> Testing
> -------
>
> c & d - don't use tabbing and it's hard to reproduce anyway and wish you much fun \
> profiling a) (btw: can i still have the callgrind results? - no, didn't ask yet ;-)
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102555/">http://git.reviewboard.kde.org/r/102555/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a obviously only for 4.7 \
branch. (I will afterwards have a look at the performance difference and might inform \
packagers about the patch as the bug has been present since ever :-()</pre> <br />
<p>- Martin</p>
<br />
<p>On September 8th, 2011, 9:16 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Sept. 8, 2011, 9:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a) replace non-const QVector::operator[] with ::at() in effects.cpp b) \
fix yet another tabbing nullpointer access... (client.cpp= c) fix \
geom_pretile/geom_restore with BorderlessMaximized (geometry.cpp) d) add missing \
connects for the kwinrules matches (title, extra,machine) (ruleswidget.cpp)
are 4 commits, stacked in one RR for convenience ;-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">c & d - don't use tabbing and it's hard to reproduce anyway \
and wish you much fun profiling a) (btw: can i still have the callgrind results? - \
no, didn't ask yet ;-)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=(279529)">(279529)</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=281506">281506</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=281596">281596</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.cpp <span style="color: grey">(e0c76cb)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(1bc3a92)</span></li>
<li>kwin/kcmkwin/kwinrules/ruleswidget.cpp <span style="color: \
grey">(300191e)</span></li>
<li>kwin/manage.cpp <span style="color: grey">(a802623)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102555/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic