'Review Request: Clear deleted window thumbnails'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Clear deleted window thumbnails
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2011-08-26 14:57:24
Message-ID: 20110826145724.25215.36625 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102445/
-----------------------------------------------------------

Review request for kwin.

Summary
-------

When thumbnails are shown and a window is deleted, only the other, still ex=
isting windows are being repainted. The deleted window stays on the screen =
until repainted. In the typical taskbar thumbnail case, that's not a proble=
m, since the thumbnail of a deleted window is just never shown (no tooltips=
 in that case).

In the Windowstrip applet, which is used as application switcher in Active,=
 when the window strip is not as wide as the screen, the windows shift left=
, leave a blank space on the right which doesn't get cleared, so a ghost of=
 the window stays on screen.

The patch addresses this by adding the rect of the vanishing window to the =
area to repaint in the next frame, essentially clearing exactly the part th=
at we want.

I'd like to commit to master and 4.7.

Diffs
-----

  kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp 7761ba5 =

Diff: http://git.reviewboard.kde.org/r/102445/diff

Testing
-------

start plasma-contour, with 3 open windows, close on of them from the window=
strip.

Without the patch, you'll see 3 windows painted, the third of which gets cl=
eared only after an artificially triggered repaint, e.g. by dragging the re=
st of the windows over it.

With the patch, behaviour is as expected, the preview of the rightmost wind=
ow is cleared.

Thanks,

Sebastian

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102445/">http://git.reviewboard.kde.org/r/102445/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Sebastian Kügler.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When thumbnails are shown and a window is deleted, only the other, still \
existing windows are being repainted. The deleted window stays on the screen until \
repainted. In the typical taskbar thumbnail case, that&#39;s not a problem, since the \
thumbnail of a deleted window is just never shown (no tooltips in that case).

In the Windowstrip applet, which is used as application switcher in Active, when the \
window strip is not as wide as the screen, the windows shift left, leave a blank \
space on the right which doesn&#39;t get cleared, so a ghost of the window stays on \
screen.

The patch addresses this by adding the rect of the vanishing window to the area to \
repaint in the next frame, essentially clearing exactly the part that we want.

I&#39;d like to commit to master and 4.7.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">start plasma-contour, with 3 open windows, close on of them from the \
windowstrip.

Without the patch, you&#39;ll see 3 windows painted, the third of which gets cleared \
only after an artificially triggered repaint, e.g. by dragging the rest of the \
windows over it.

With the patch, behaviour is as expected, the preview of the rightmost window is \
cleared.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp <span style="color: \
grey">(7761ba5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102445/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 