[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Implement Decoration Policy
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-08-26 13:01:58
Message-ID: 20110826130158.19319.78677 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102434/#review6024
-----------------------------------------------------------
And if you remove _KDE_NET_WM_WINDOW_TYPE_OVERRIDE then what? Qt docks bein=
g decorated twice just like kruler once and yakuake - but only if there's a=
rectangular shape?
Until then _every_ Qt application will remain completely unchaged in this r=
egard (since the Qt::FramelessWindowHint does set the property)
If it's about getting rid of motif hints, that's fine (we'll add a real _ne=
t_wm hint then) but if it's only about chromium or stupid CSD is back on th=
e tapet (is it?), that's a social problem but iff we /have/ to fix it techn=
ically, there're better ways.
Otherwise you can expect a "chromium broken on KDE" bugreport quite soon an=
d chromium devs to be smart enough to (surprise ;-) google or just check ho=
w KDE apps do it and then add this property as well to their next release (=
since they're probably not stupid)
Sorry, I don't want to be mean or demotivating, but in the latter case this=
looks a bit like a quick shot to me - and I do not think it would work at =
all.
kwin/client.cpp
<http://git.reviewboard.kde.org/r/102434/#comment5310>
Can you please elaborate on this?
What makes keep_above windows special against other shaped ones in this=
regard?
=
It sounds very much like a special case* and has a solution to me - wha=
t would mean that -motif or not- we actually need either a hint for this or=
"smarter" handling of shaped clients or fix the clients, but i do not see =
any reason to treat them different just because of the keep_above flag, sor=
ry.
=
Also i object the way it's done.
Iff the decoration (of shaped clients) depends on the keep_above state=
it should change whenever this state changes (what's actually confusing en=
ough) and not indirectly after the next shape change (check keep above, sta=
rt resize -> deco gone. this looks like a bug to the user)
=
-------------
* /cough/ yakuake /cough/ which is btw. *not* shaped here (square theme=
images), *does* set _KDE_NET_WM_WINDOW_TYPE_OVERRIDE anyway and actually w=
ants to be an override-redirect window just like the Qt docks probably want=
to be. (meaning they have to do stacking and focus by themselves)
- Thomas
On Aug. 25, 2011, 7:05 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102434/
> -----------------------------------------------------------
> =
> (Updated Aug. 25, 2011, 7:05 p.m.)
> =
> =
> Review request for kwin and Plasma.
> =
> =
> Summary
> -------
> =
> Implements the decoration policy as described here: http://techbase.kde.o=
rg/Projects/KWin/Window_Decoration_Policy
> =
> The following changes are performed:
> * remove support for motif_nodeco hint
> * styled windows get window decorations unless they are keep above (means=
if you set Chromium to keep above and resize it, the decoration are remove=
d)
> =
> This "breaks" Chromium and xeyes with +style. It is still possible to use=
the normal no-border mode either through Alt+F3 settings or window rule. A=
nd it's still possible to hack around through the way how Qt Dock widgets r=
equest no deco. This is something I did not change, if application authors =
find it, I would probably change it as it is marked as a non-standard, non-=
documented feature ;-)
> =
> I would suggest to commit and try it at least in master and see whether i=
t unleashes hell upon us :-)
> =
> =
> Diffs
> -----
> =
> kwin/client.h 66b9c46 =
> kwin/client.cpp a6f0618 =
> =
> Diff: http://git.reviewboard.kde.org/r/102434/diff
> =
> =
> Testing
> -------
> =
> * Yakuake still is without deco
> * All Plasma windows are without deco
> * Qt Dock widgets are without deco
> * KRuler is without deco
> * Chromium is forced to have deco
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102434/">http://git.reviewboard.kde.org/r/102434/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And if you remove \
_KDE_NET_WM_WINDOW_TYPE_OVERRIDE then what? Qt docks being decorated twice just like \
kruler once and yakuake - but only if there's a rectangular shape? Until then \
_every_ Qt application will remain completely unchaged in this regard (since the \
Qt::FramelessWindowHint does set the property)
If it's about getting rid of motif hints, that's fine (we'll add a real \
_net_wm hint then) but if it's only about chromium or stupid CSD is back on the \
tapet (is it?), that's a social problem but iff we /have/ to fix it technically, \
there're better ways.
Otherwise you can expect a "chromium broken on KDE" bugreport quite soon \
and chromium devs to be smart enough to (surprise ;-) google or just check how KDE \
apps do it and then add this property as well to their next release (since \
they're probably not stupid)
Sorry, I don't want to be mean or demotivating, but in the latter case this looks \
a bit like a quick shot to me - and I do not think it would work at all.</pre> <br \
/>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102434/diff/1/?file=32893#file32893line772" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/client.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Client::checkNoBorder()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">772</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">app_noborder</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">771</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="c1">// they should have \
decorations - except for kept above</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you \
please elaborate on this? What makes keep_above windows special against other shaped \
ones in this regard?
It sounds very much like a special case* and has a solution to me - what would mean \
that -motif or not- we actually need either a hint for this or "smarter" \
handling of shaped clients or fix the clients, but i do not see any reason to treat \
them different just because of the keep_above flag, sorry.
Also i object the way it's done.
Iff the decoration (of shaped clients) depends on the keep_above state it should \
change whenever this state changes (what's actually confusing enough) and not \
indirectly after the next shape change (check keep above, start resize -> deco \
gone. this looks like a bug to the user)
-------------
* /cough/ yakuake /cough/ which is btw. *not* shaped here (square theme images), \
*does* set _KDE_NET_WM_WINDOW_TYPE_OVERRIDE anyway and actually wants to be an \
override-redirect window just like the Qt docks probably want to be. (meaning they \
have to do stacking and focus by themselves)</pre> </div>
<br />
<p>- Thomas</p>
<br />
<p>On August 25th, 2011, 7:05 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2011, 7:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implements the decoration policy as described here: \
http://techbase.kde.org/Projects/KWin/Window_Decoration_Policy
The following changes are performed:
* remove support for motif_nodeco hint
* styled windows get window decorations unless they are keep above (means if you set \
Chromium to keep above and resize it, the decoration are removed)
This "breaks" Chromium and xeyes with +style. It is still possible to use \
the normal no-border mode either through Alt+F3 settings or window rule. And it's \
still possible to hack around through the way how Qt Dock widgets request no deco. \
This is something I did not change, if application authors find it, I would probably \
change it as it is marked as a non-standard, non-documented feature ;-)
I would suggest to commit and try it at least in master and see whether it unleashes \
hell upon us :-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Yakuake still is without deco
* All Plasma windows are without deco
* Qt Dock widgets are without deco
* KRuler is without deco
* Chromium is forced to have deco</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.h <span style="color: grey">(66b9c46)</span></li>
<li>kwin/client.cpp <span style="color: grey">(a6f0618)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102434/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic