'Review Request: Implement Decoration Policy'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Implement Decoration Policy
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-08-25 19:05:10
Message-ID: 20110825190510.1840.81744 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102434/
-----------------------------------------------------------

Review request for kwin and Plasma.

Summary
-------

Implements the decoration policy as described here: http://techbase.kde.org=
/Projects/KWin/Window_Decoration_Policy

The following changes are performed:
* remove support for motif_nodeco hint
* styled windows get window decorations unless they are keep above (means i=
f you set Chromium to keep above and resize it, the decoration are removed)

This "breaks" Chromium and xeyes with +style. It is still possible to use t=
he normal no-border mode either through Alt+F3 settings or window rule. And=
 it's still possible to hack around through the way how Qt Dock widgets req=
uest no deco. This is something I did not change, if application authors fi=
nd it, I would probably change it as it is marked as a non-standard, non-do=
cumented feature ;-)

I would suggest to commit and try it at least in master and see whether it =
unleashes hell upon us :-)

Diffs
-----

  kwin/client.h 66b9c46 =

  kwin/client.cpp a6f0618 =

Diff: http://git.reviewboard.kde.org/r/102434/diff

Testing
-------

* Yakuake still is without deco
* All Plasma windows are without deco
* Qt Dock widgets are without deco
* KRuler is without deco
* Chromium is forced to have deco

Thanks,

Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102434/">http://git.reviewboard.kde.org/r/102434/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implements the decoration policy as described here: \
http://techbase.kde.org/Projects/KWin/Window_Decoration_Policy

The following changes are performed:
* remove support for motif_nodeco hint
* styled windows get window decorations unless they are keep above (means if you set \
Chromium to keep above and resize it, the decoration are removed)

This &quot;breaks&quot; Chromium and xeyes with +style. It is still possible to use \
the normal no-border mode either through Alt+F3 settings or window rule. And it&#39;s \
still possible to hack around through the way how Qt Dock widgets request no deco. \
This is something I did not change, if application authors find it, I would probably \
change it as it is marked as a non-standard, non-documented feature ;-)

I would suggest to commit and try it at least in master and see whether it unleashes \
hell upon us :-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* Yakuake still is without deco
* All Plasma windows are without deco
* Qt Dock widgets are without deco
* KRuler is without deco
* Chromium is forced to have deco</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(66b9c46)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(a6f0618)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102434/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 