From kwin Thu Aug 25 00:27:27 2011 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Thu, 25 Aug 2011 00:27:27 +0000 To: kwin Subject: Review Request: Fix tiling code, basically pointer handing Message-Id: <20110825002727.15816.2312 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=131423208623644 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0416546527069578293==" --===============0416546527069578293== Content-Type: multipart/alternative; boundary="===============0060852029495092498==" --===============0060852029495092498== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102424/ ----------------------------------------------------------- Review request for kwin, Nikhil Shantanu Marathe and Martin Gr=C3=A4=C3=9Fl= in. Summary ------- Code post-commit review & patch. Sorry if it sounds grumpy - it's late and i wanted to see a Loriot video in= stead. I read across the tiling code. Looks valid otherewise (ie. the other unchec= ked pointers should all be checked by the calling functions) This addresses bug 274223. http://bugs.kde.org/show_bug.cgi?id=3D274223 Diffs ----- kwin/tile.cpp a188129 = kwin/tiling.cpp 85b2227 = kwin/tilinglayout.cpp 6e1152b = Diff: http://git.reviewboard.kde.org/r/102424/diff Testing ------- Yes, Meta + f will just do nothing when no client is active. Thanks, Thomas --===============0060852029495092498== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102424/

Review request for kwin, Nikhil Shantanu Marathe and Martin Gr=C3=A4= =C3=9Flin.
By Thomas L=C3=BCbking.

Descripti= on 

Code post-commit review & patch.
Sorry if it sounds grumpy - it's late and i wanted to see a Loriot vide=
o instead.

I read across the tiling code. Looks valid otherewise (ie. the other unchec=
ked pointers should all be checked by the calling functions)

Testing <= /h1> 
Yes, Meta + f will just do nothing when no client is active.=
Bugs: 274223

Diffs=

  • kwin/tile.cpp (a188129)
  • kwin/tiling.cpp (85b2227)
  • kwin/tilinglayout.cpp (6e1152b)

View Diff
--===============0060852029495092498==-- --===============0416546527069578293== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============0416546527069578293==--