From kwin Thu Aug 18 20:03:26 2011 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Thu, 18 Aug 2011 20:03:26 +0000 To: kwin Subject: Review Request: Add two options regarding mouse invocation when Message-Id: <20110818200326.20330.19815 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=131369783829901 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1224208969387328298==" --===============1224208969387328298== Content-Type: multipart/alternative; boundary="===============6203351630188507451==" --===============6203351630188507451== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102371/ ----------------------------------------------------------- Review request for kwin and Martin Gr=C3=A4=C3=9Flin. Summary ------- Passing the on the focus to the client under the mouse makes sense in a mou= se driven focus scheme like FFM (but i didn't restrict it, so it can be use= d with CTF as well) Whether ensureing the pointer to be under the currently active window makes= sense or is sane, i don't know. I know that E17 has it, that it's a comple= ment to the above, and that it's pretty much a one liner. *shrug* This addresses bugs 80897 and 159989. http://bugs.kde.org/show_bug.cgi?id=3D80897 http://bugs.kde.org/show_bug.cgi?id=3D159989 Diffs ----- kwin/activation.cpp 911e9e6 = kwin/kcmkwin/kwinoptions/windows.h f7a8658 = kwin/kcmkwin/kwinoptions/windows.cpp ad20a8a = kwin/options.h 4dab3ac = kwin/options.cpp 6522e44 = Diff: http://git.reviewboard.kde.org/r/102371/diff Testing ------- Yes, focus end up under mouse w/ and in focus chain w/o. Cursor jumps corre= ctly in a single screen setup (moeved back the other screen - but given tha= t xrandr is just a HUUUGE screen area, i doubt it makes any difference) Thanks, Thomas --===============6203351630188507451== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102371/

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

By Thomas L=C3=BCbking.

Descripti= on

Passing the on the focus to the client under the mouse makes=
 sense in a mouse driven focus scheme like FFM (but i didn't restrict i=
t, so it can be used with CTF as well)
Whether ensureing the pointer to be under the currently active window makes=
 sense or is sane, i don't know. I know that E17 has it, that it's =
a complement to the above, and that it's pretty much a one liner. *shru=
g*

Testing <= /h1>

Yes, focus end up under mouse w/ and in focus chain w/o. Cur=
sor jumps correctly in a single screen setup (moeved back the other screen =
- but given that xrandr is just a HUUUGE screen area, i doubt it makes any =
difference)

Bugs: 80897, = 159989

Diffs=

kwin/activation.cpp (911e9e6)
kwin/kcmkwin/kwinoptions/windows.h (f7a865= 8)
kwin/kcmkwin/kwinoptions/windows.cpp (ad20= a8a)
kwin/options.h (4dab3ac)
kwin/options.cpp (6522e44)

--===============6203351630188507451==-- --===============1224208969387328298== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1224208969387328298==--