[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Restore behaviour of max'd clients when being
From: "Commit Hook" <null () kde ! org>
Date: 2011-08-15 21:03:16
Message-ID: 20110815210316.7466.39119 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102237/#review5730
-----------------------------------------------------------
This review has been submitted with commit 362a438ba7fd7c9d682632386644b5f7b7e4fe82 \
by Thomas Lübking to branch master.
- Commit
On Aug. 6, 2011, 11:56 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102237/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2011, 11:56 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> a) Fixes bug 279529 by adjusting restore geometry to current and unmaximize client \
> when being moveResized b) what i ran into when testing: since we do no more rely on \
> the geometry reg. the maximization state, we can actually treat clients with a max \
> size as still maximizable, the client will just change to that max. size (similar \
> happens unidirectional for clients with fixed aspect) c) as a consequence of b) i \
> changed the gravity of max'd clients NOT covering the clientArea to be centered \
> (makes imo more sense, try maximizing eg. mplayer - atm it will end up on the upper \
> part of the screen)
> a) should clearly be in 4.7, b & c are more "improvements" than bugfixes, yet quite \
> minor changes and get you some semi-zoom feature alongside the rules. --> your \
> choice :)
>
> This addresses bug 279529.
> http://bugs.kde.org/show_bug.cgi?id=279529
>
>
> Diffs
> -----
>
> kwin/geometry.cpp 2bc059c
>
> Diff: http://git.reviewboard.kde.org/r/102237/diff
>
>
> Testing
> -------
>
> Maximizing. A whole lot of maximizing. With moveResize, aer... "quick \
> maximization", without either and both.
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102237/">http://git.reviewboard.kde.org/r/102237/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 362a438ba7fd7c9d682632386644b5f7b7e4fe82 by Thomas Lübking to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 6th, 2011, 11:56 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2011, 11:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a) Fixes bug 279529 by adjusting restore geometry to current and \
unmaximize client when being moveResized b) what i ran into when testing: since we do \
no more rely on the geometry reg. the maximization state, we can actually treat \
clients with a max size as still maximizable, the client will just change to that \
max. size (similar happens unidirectional for clients with fixed aspect) c) as a \
consequence of b) i changed the gravity of max'd clients NOT covering the \
clientArea to be centered (makes imo more sense, try maximizing eg. mplayer - atm it \
will end up on the upper part of the screen)
a) should clearly be in 4.7, b & c are more "improvements" than \
bugfixes, yet quite minor changes and get you some semi-zoom feature alongside the \
rules. --> your choice :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Maximizing. A whole lot of maximizing. With moveResize, aer... \
"quick maximization", without either and both.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279529">279529</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/geometry.cpp <span style="color: grey">(2bc059c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102237/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic