[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Respect custom title bar button settings in
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-08-14 14:00:35
Message-ID: 20110814140035.14692.90632 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 19, 2011, 7:02 p.m., Thomas Lübking wrote:
> > a) -> https://git.reviewboard.kde.org/r/101318/
> > b) this way is probably not sufficient since decoration like Aurorae could \
> > possibly ignore that setting in general.
> > The solution would be to propagate the decoration (or some of it's settings) to \
> > the effects and ask the current decotation about the location of the close \
> > button.
>
> Kai Uwe Broulik wrote:
> Hm, right, didn't think of Aurorae but who wants it on the left could manually set \
> the buttons *g* Or another approach: Add a dropdown box to the present windows \
> effect where you could chose the position: "No close button", "Left", "Right" or \
> so.
As Thomas's review has been committed, I think this one can be closed. Nevertheless \
thanks for the patch.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102011/#review4863
-----------------------------------------------------------
On July 19, 2011, 6:56 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102011/
> -----------------------------------------------------------
>
> (Updated July 19, 2011, 6:56 p.m.)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> This patch reads kwinrc and looks whether there is the "X" in ButtonsOnLeft and \
> then moves the overlay window close button to the left, otherwise it stays at its \
> default right position. It also honors the CustomButtonPosition config entry and \
> the behavior can be disabled with "RespectCustomButtons=false" in presentwindows \
> effect rc.
>
> Diffs
> -----
>
> kwin/effects/presentwindows/presentwindows.h 58c5266
> kwin/effects/presentwindows/presentwindows.cpp a0e8306
>
> Diff: http://git.reviewboard.kde.org/r/102011/diff
>
>
> Testing
> -------
>
> Compiles and runs fine. Changing button position or disabling custom button \
> placement in kwin decoration settings makes the present windows close button adapt \
> to the new situation.
>
> Thanks,
>
> Kai Uwe
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102011/">http://git.reviewboard.kde.org/r/102011/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 19th, 2011, 7:02 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a) -> https://git.reviewboard.kde.org/r/101318/ b) this way is \
probably not sufficient since decoration like Aurorae could possibly ignore that \
setting in general.
The solution would be to propagate the decoration (or some of it's settings) to \
the effects and ask the current decotation about the location of the close \
button.</pre> </blockquote>
<p>On July 19th, 2011, 10:35 p.m., <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, right, didn't think \
of Aurorae but who wants it on the left could manually set the buttons *g* Or another \
approach: Add a dropdown box to the present windows effect where you could chose the \
position: "No close button", "Left", "Right" or \
so.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As Thomas's review \
has been committed, I think this one can be closed. Nevertheless thanks for the \
patch.</pre> <br />
<p>- Martin</p>
<br />
<p>On July 19th, 2011, 6:56 p.m., Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated July 19, 2011, 6:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch reads kwinrc and looks whether there is the "X" in \
ButtonsOnLeft and then moves the overlay window close button to the left, otherwise \
it stays at its default right position. It also honors the CustomButtonPosition \
config entry and the behavior can be disabled with \
"RespectCustomButtons=false" in presentwindows effect rc. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and runs fine. Changing button position or disabling custom \
button placement in kwin decoration settings makes the present windows close button \
adapt to the new situation.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/presentwindows/presentwindows.h <span style="color: \
grey">(58c5266)</span></li>
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(a0e8306)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102011/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic