[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Move the "Lock Session" shortcut to kwin from
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-08-11 10:05:28
Message-ID: 20110811100528.11731.83498 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102261/#review5626
-----------------------------------------------------------
Ship it!
- Martin
On Aug. 9, 2011, 2:42 p.m., Alex Merry wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102261/
> -----------------------------------------------------------
> =
> (Updated Aug. 9, 2011, 2:42 p.m.)
> =
> =
> Review request for kwin, Plasma, Aaron J. Seigo, Martin Gr=C3=A4=C3=9Flin=
, and Farhad Hedayati Fard.
> =
> =
> Summary
> -------
> =
> In the farhad_hf/lockscreen branch (that moves screen locking functionali=
ty from krunner to kwin), the shortcut for locking the screen (Ctrl+Alt+L b=
y default) remains in KRunner, which will not necessarily be running (when =
plasma is in "netbook" mode, for example). This moves the shortcut registr=
ation to kwin (including a necessary hack for unregistering krunner's claim=
on it).
> =
> (See also https://git.reviewboard.kde.org/r/101943/ ).
> =
> I can also merge latest master into the branch and/or add in a KWIN_BUILD=
_SCREENSAVER cmake option (as in the original review request) if you (Marti=
n/Farhad) want.
> =
> =
> Diffs
> -----
> =
> krunner/krunnerapp.cpp 55ac5ca =
> kwin/kwinbindings.cpp 40bba26 =
> kwin/screenlocker/screensaver/saverengine.h 3384d4a =
> kwin/screenlocker/screensaver/saverengine.cpp 6c15be6 =
> kwin/useractions.cpp 44685b9 =
> kwin/workspace.h 2b4c8e9 =
> =
> Diff: http://git.reviewboard.kde.org/r/102261/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Alex
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102261/">http://git.reviewboard.kde.org/r/102261/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Martin</p>
<br />
<p>On August 9th, 2011, 2:42 p.m., Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma, Aaron J. Seigo, Martin Gräßlin, and Farhad \
Hedayati Fard.</div> <div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2011, 2:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In the farhad_hf/lockscreen branch (that moves screen locking \
functionality from krunner to kwin), the shortcut for locking the screen (Ctrl+Alt+L \
by default) remains in KRunner, which will not necessarily be running (when plasma is \
in "netbook" mode, for example). This moves the shortcut registration to \
kwin (including a necessary hack for unregistering krunner's claim on it).
(See also https://git.reviewboard.kde.org/r/101943/ ).
I can also merge latest master into the branch and/or add in a KWIN_BUILD_SCREENSAVER \
cmake option (as in the original review request) if you (Martin/Farhad) want.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krunner/krunnerapp.cpp <span style="color: grey">(55ac5ca)</span></li>
<li>kwin/kwinbindings.cpp <span style="color: grey">(40bba26)</span></li>
<li>kwin/screenlocker/screensaver/saverengine.h <span style="color: \
grey">(3384d4a)</span></li>
<li>kwin/screenlocker/screensaver/saverengine.cpp <span style="color: \
grey">(6c15be6)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(44685b9)</span></li>
<li>kwin/workspace.h <span style="color: grey">(2b4c8e9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102261/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic