'Re: Review Request: 1 leak,'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: 1 leak,
From:       "Commit Hook" <null () kde ! org>
Date:       2011-08-02 15:28:39
Message-ID: 20110802152839.7691.69419 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102057/#review5321
-----------------------------------------------------------

This review has been submitted with commit 169a3d887d58aaaae7457a8ae3003478=
b78e8f3b by Jaime Torres to branch master.

- Commit

On Aug. 1, 2011, 5:59 p.m., Jaime Torres Amate wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102057/
> -----------------------------------------------------------
> =

> (Updated Aug. 1, 2011, 5:59 p.m.)
> =

> =

> Review request for kwin.
> =

> =

> Summary
> -------
> =

> Some minor performance .. prefix ++ for non atomic types.
> Remove the leak for library.
> Reduce the scope for two variables.
> Avoid the modification of a parameter pointer pointing to the local stack=
 when it was NULL.
> Avoid the use of deco before it is sure is not NULL.
> =

> =

> Diffs
> -----
> =

>   kwin/clientgroup.cpp f8604b6 =

>   kwin/clients/oxygen/oxygenexceptionlist.cpp 652dda0 =

>   kwin/effects.cpp 143b033 =

>   kwin/effects/blur/blurshader.cpp e7e5bf3 =

>   kwin/effects/coverswitch/coverswitch.cpp 6bc98b3 =

>   kwin/effects/presentwindows/presentwindows.cpp a0e8306 =

>   kwin/effects/slidingpopups/slidingpopups.cpp 34bdac4 =

>   kwin/kcmkwin/kwinrules/ruleswidget.cpp c3a44df =

>   kwin/libkwineffects/kwineffects.cpp e0c5538 =

>   kwin/tools/decobenchmark/preview.cpp 36cfcd1 =

>   kwin/useractions.cpp 387e499 =

>   kwin/workspace.cpp b955668 =

> =

> Diff: http://git.reviewboard.kde.org/r/102057/diff
> =

> =

> Testing
> -------
> =

> Working with the patch applied.
> =

> =

> Thanks,
> =

> Jaime Torres
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102057/">http://git.reviewboard.kde.org/r/102057/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 169a3d887d58aaaae7457a8ae3003478b78e8f3b by Jaime Torres to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 1st, 2011, 5:59 p.m., Jaime Torres Amate wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated Aug. 1, 2011, 5:59 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some minor performance .. prefix ++ for non atomic types. Remove the \
leak for library. Reduce the scope for two variables.
Avoid the modification of a parameter pointer pointing to the local stack when it was \
NULL. Avoid the use of deco before it is sure is not NULL.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Working with the patch applied.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clientgroup.cpp <span style="color: grey">(f8604b6)</span></li>

 <li>kwin/clients/oxygen/oxygenexceptionlist.cpp <span style="color: \
grey">(652dda0)</span></li>

 <li>kwin/effects.cpp <span style="color: grey">(143b033)</span></li>

 <li>kwin/effects/blur/blurshader.cpp <span style="color: grey">(e7e5bf3)</span></li>

 <li>kwin/effects/coverswitch/coverswitch.cpp <span style="color: \
grey">(6bc98b3)</span></li>

 <li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(a0e8306)</span></li>

 <li>kwin/effects/slidingpopups/slidingpopups.cpp <span style="color: \
grey">(34bdac4)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidget.cpp <span style="color: \
grey">(c3a44df)</span></li>

 <li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(e0c5538)</span></li>

 <li>kwin/tools/decobenchmark/preview.cpp <span style="color: \
grey">(36cfcd1)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(387e499)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(b955668)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102057/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 