[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: With tiling only change focus on one monitor.
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-07-31 16:09:25
Message-ID: 20110731160925.21715.25874 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 31, 2011, 3:56 p.m., Martin Gräßlin wrote:
> > kwin/tiling/tiling.cpp, lines 298-299
> > <http://git.reviewboard.kde.org/r/102164/diff/1/?file=30478#file30478line298>
> >
> > yeah that can be done in a better way. Try
> > t->client()->isOnScreen(activeScreen)
FTR: this will hit any partial intersection and actually there's Topleve::screen() \
but it checks the center position... -> int Toplevel::mainScreen()?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102164/#review5277
-----------------------------------------------------------
On July 31, 2011, 3:21 p.m., Matthias Fuchs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102164/
> -----------------------------------------------------------
>
> (Updated July 31, 2011, 3:21 p.m.)
>
>
> Review request for kwin, Nikhil Shantanu Marathe and Arthur Arlt.
>
>
> Summary
> -------
>
> Only raise a client if it is on the same screen as the activated window.
>
> I think that my code is not that nice, is there a better way to do it?
>
>
> This addresses bug 243203.
> http://bugs.kde.org/show_bug.cgi?id=243203
>
>
> Diffs
> -----
>
> kwin/tiling/tiling.cpp 0b8fb95
>
> Diff: http://git.reviewboard.kde.org/r/102164/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matthias
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102164/">http://git.reviewboard.kde.org/r/102164/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 31st, 2011, 3:56 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102164/diff/1/?file=30478#file30478line298" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/tiling/tiling.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Tiling::notifyTilingWindowActivated(KWin::Client *c)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">298</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">const</span> <span class="kt">int</span> <span \
class="n">screen</span> <span class="o">=</span> <span \
class="n">m_workspace</span><span class="o">-></span><span \
class="n">screenNumber</span><span class="p">(</span><span class="n">t</span><span \
class="o">-></span><span class="n">client</span><span class="p">()</span><span \
class="o">-></span><span class="n">geometry</span><span class="p">().</span><span \
class="n">topLeft</span><span class="p">());</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">299</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">activeScreen</span> \
<span class="o">==</span> <span class="n">screen</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yeah that can be done in \
a better way. Try t->client()->isOnScreen(activeScreen)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FTR: this \
will hit any partial intersection and actually there's Topleve::screen() but it \
checks the center position... -> int Toplevel::mainScreen()?</pre> <br />
<p>- Thomas</p>
<br />
<p>On July 31st, 2011, 3:21 p.m., Matthias Fuchs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Nikhil Shantanu Marathe and Arthur Arlt.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated July 31, 2011, 3:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Only raise a client if it is on the same screen as the activated window.
I think that my code is not that nice, is there a better way to do it?</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=243203">243203</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tiling/tiling.cpp <span style="color: grey">(0b8fb95)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102164/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic