[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Drop option to select direct rendering
From: "Commit Hook" <null () kde ! org>
Date: 2011-07-31 15:46:01
Message-ID: 20110731154601.20398.8204 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102074/#review5275
-----------------------------------------------------------
This review has been submitted with commit fcf6eaa9290a0f1f19683e621595e114=
b908ddea by Martin Gr=C3=A4=C3=9Flin to branch master.
- Commit
On July 24, 2011, 1:44 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102074/
> -----------------------------------------------------------
> =
> (Updated July 24, 2011, 1:44 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Summary
> -------
> =
> The advanced compositing option "direct rendering" could only correctly b=
e honored in the case of proprietary NVIDIA drivers. In all cases playing w=
ith the setting was most likely harmful as it could result in inconsistent =
states and the option not to be honored at all.
> =
> This patch resolves this issue by moving the detection whether to use a d=
irect rendering context completely into the hands of the set environment va=
riables or the helper program:
> * if LIBGL_ALWAYS_INDIRECT is set, we use an indirect context
> * if KWIN_DIRECT_GL is set, we use a direct context
> * if none of the two are set, we use the helper program, if it returns 0 =
we create a direct context, otherwise we set LIBGL_ALWAYS_INDIRECT and crea=
te an indirect context
> =
> If a user really wants to influence the behavior (and I doubt that) the e=
nvironment variables can be used.
> =
> =
> Diffs
> -----
> =
> kwin/compositingprefs.cpp 025048e =
> kwin/kcmkwin/kwincompositing/main.cpp f39ace1 =
> kwin/kcmkwin/kwincompositing/main.ui ed3da09 =
> kwin/options.cpp 09a3163 =
> =
> Diff: http://git.reviewboard.kde.org/r/102074/diff
> =
> =
> Testing
> -------
> =
> * without any environment variable a direct rendering context is created =
on my R600
> * with LIBGL_ALWAYS_INDIRECT an indirect rendering context is created on =
my R600
> =
> other possible combinations (e.g. NVIDIA) not tested.
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102074/">http://git.reviewboard.kde.org/r/102074/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit fcf6eaa9290a0f1f19683e621595e114b908ddea by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 24th, 2011, 1:44 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 24, 2011, 1:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The advanced compositing option "direct rendering" could only \
correctly be honored in the case of proprietary NVIDIA drivers. In all cases playing \
with the setting was most likely harmful as it could result in inconsistent states \
and the option not to be honored at all.
This patch resolves this issue by moving the detection whether to use a direct \
rendering context completely into the hands of the set environment variables or the \
helper program:
* if LIBGL_ALWAYS_INDIRECT is set, we use an indirect context
* if KWIN_DIRECT_GL is set, we use a direct context
* if none of the two are set, we use the helper program, if it returns 0 we create a \
direct context, otherwise we set LIBGL_ALWAYS_INDIRECT and create an indirect context
If a user really wants to influence the behavior (and I doubt that) the environment \
variables can be used.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* without any environment variable a direct rendering context is created \
on my R600
* with LIBGL_ALWAYS_INDIRECT an indirect rendering context is created on my R600
other possible combinations (e.g. NVIDIA) not tested.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/compositingprefs.cpp <span style="color: grey">(025048e)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(f39ace1)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.ui <span style="color: \
grey">(ed3da09)</span></li>
<li>kwin/options.cpp <span style="color: grey">(09a3163)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102074/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic