'Re: Review Request: Dragging a fullscreen window to another screen'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Dragging a fullscreen window to another screen
From:       "Matthias Fuchs" <mat69 () gmx ! net>
Date:       2011-07-28 21:54:31
Message-ID: 20110728215431.29212.18867 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102103/
-----------------------------------------------------------

(Updated July 28, 2011, 9:54 p.m.)

Review request for kwin and Martin Gräßlin.

Changes
-------

Uses checkWorkspacePosition and also takes xineramaFullscreenEnabled into \
consideration.

@Thomas the patch you linked is not in branch 4.7 but just master, so I tested the \
patch you linked only with master. Yet I want to backport this review here also to \
4.7, but as far as I can tell it works nice with both master and 4.7.

Summary
-------

I think the screen number solution is not ideal, though it works.
What do you think?

This addresses bug 261704.
    http://bugs.kde.org/show_bug.cgi?id=261704

Diffs (updated)
-----

  kwin/client.h 93510ec 
  kwin/geometry.cpp 5c0f303 

Diff: http://git.reviewboard.kde.org/r/102103/diff

Testing
-------

Tested with two screens with the 4.7 branch and the master branch.

Thanks,

Matthias

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102103/">http://git.reviewboard.kde.org/r/102103/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Matthias Fuchs.</div>

<p style="color: grey;"><i>Updated July 28, 2011, 9:54 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Uses checkWorkspacePosition and also takes xineramaFullscreenEnabled \
into consideration.

@Thomas the patch you linked is not in branch 4.7 but just master, so I tested the \
patch you linked only with master. Yet I want to backport this review here also to \
4.7, but as far as I can tell it works nice with both master and 4.7.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I think the screen number solution is not ideal, though it works. What \
do you think?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with two screens with the 4.7 branch and the master branch.</pre> \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=261704">261704</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(93510ec)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(5c0f303)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102103/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 