'Re: Review Request: Move Tiling functionality to an own class and'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Move Tiling functionality to an own class and
From:       "Commit Hook" <null () kde ! org>
Date:       2011-07-28 11:55:50
Message-ID: 20110728115550.17848.54809 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102020/#review5170
-----------------------------------------------------------

This review has been submitted with commit f6ea3d05992eaf84e7c407cc8d603533=
452f3ea9 by Arthur Arlt to branch master.

- Commit

On July 20, 2011, 2:06 p.m., Arthur Arlt wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102020/
> -----------------------------------------------------------
> =

> (Updated July 20, 2011, 2:06 p.m.)
> =

> =

> Review request for kwin and Nikhil Shantanu Marathe.
> =

> =

> Summary
> -------
> =

> This patch moves the Tiling functionality from Workspace to an own class =
Tiling. The formerly used file tiling.cpp was moved to an own directory til=
ing/ and adjusted to the new class. A new header file tiling.h is introduce=
d as well.
> All function calls were adjusted to use the new class Tiling now and some=
 were replaced to use signal and slot mechanism.
> =

> Furthermore a build option was added to make it possible to disable build=
ing that feature. It is already added to the Plasma Active build option and=
 set to OFF.
> =

> =

> Diffs
> -----
> =

>   kwin/tiling/tiling.h PRE-CREATION =

>   kwin/tile.cpp a188129 =

>   kwin/tiling.cpp 85b2227 =

>   kwin/sm.cpp db44ce0 =

>   kwin/kwinbindings.cpp 0d81857 =

>   kwin/activation.cpp 1f67f96 =

>   kwin/client.cpp c4fdd95 =

>   kwin/config-kwin.h.cmake 8c8c9d9 =

>   kwin/geometry.cpp 04c7b9d =

>   kwin/CMakeLists.txt 4859978 =

>   kwin/tiling/tiling.cpp PRE-CREATION =

>   kwin/tilinglayout.h 687d28c =

>   kwin/tilinglayout.cpp 6e1152b =

>   kwin/useractions.cpp 387e499 =

>   kwin/workspace.h fa3d7bd =

>   kwin/workspace.cpp 1a48194 =

> =

> Diff: http://git.reviewboard.kde.org/r/102020/diff
> =

> =

> Testing
> -------
> =

> Compiles and runs. No regressions on my system. Since I do not know the w=
hole functionality of Tiling, it would be nice if someone who uses/knows it=
 can test my changes. =

> =

> =

> Thanks,
> =

> Arthur
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102020/">http://git.reviewboard.kde.org/r/102020/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f6ea3d05992eaf84e7c407cc8d603533452f3ea9 by Arthur Arlt to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 20th, 2011, 2:06 p.m., Arthur Arlt wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Nikhil Shantanu Marathe.</div>
<div>By Arthur Arlt.</div>

<p style="color: grey;"><i>Updated July 20, 2011, 2:06 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch moves the Tiling functionality from Workspace to an own class \
Tiling. The formerly used file tiling.cpp was moved to an own directory tiling/ and \
adjusted to the new class. A new header file tiling.h is introduced as well. All \
function calls were adjusted to use the new class Tiling now and some were replaced \
to use signal and slot mechanism.

Furthermore a build option was added to make it possible to disable building that \
feature. It is already added to the Plasma Active build option and set to OFF.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and runs. No regressions on my system. Since I do not know the \
whole functionality of Tiling, it would be nice if someone who uses/knows it can test \
my changes. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/tiling/tiling.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kwin/tile.cpp <span style="color: grey">(a188129)</span></li>

 <li>kwin/tiling.cpp <span style="color: grey">(85b2227)</span></li>

 <li>kwin/sm.cpp <span style="color: grey">(db44ce0)</span></li>

 <li>kwin/kwinbindings.cpp <span style="color: grey">(0d81857)</span></li>

 <li>kwin/activation.cpp <span style="color: grey">(1f67f96)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(c4fdd95)</span></li>

 <li>kwin/config-kwin.h.cmake <span style="color: grey">(8c8c9d9)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(04c7b9d)</span></li>

 <li>kwin/CMakeLists.txt <span style="color: grey">(4859978)</span></li>

 <li>kwin/tiling/tiling.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kwin/tilinglayout.h <span style="color: grey">(687d28c)</span></li>

 <li>kwin/tilinglayout.cpp <span style="color: grey">(6e1152b)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(387e499)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(fa3d7bd)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(1a48194)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102020/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 